Download persistence system revamp #225
Merged
cranci1 merged 5 commits intocranci1:devfrom Jul 15, 2025
Merged
Conversation
New DownloadPersistence utility to handle the loading, saving, and deleting of downloaded assets using a JSON file and UserDefaults. Updated JSController to utilize this new persistence layer and migration from the previous UserDefaults implementation.
Owner
|
You didn't need to send the entire AI resume 😭😭😭 |
cranci1
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
1. Persistence Layer Migration
Replaced all usages of:
UserDefaults.standard.data(forKey: "downloadedAssets")UserDefaults.standard.set(data, forKey: "downloadedAssets")savedAssets.append(...)savedAssets.removeAll { $0.id == id }Now uses:
DownloadPersistence.load()DownloadPersistence.save(assets)DownloadPersistence.upsert(newAsset)DownloadPersistence.delete(id: id)2. Reactive Downloaded View
savedAssetsis reloaded from disk.objectWillChange.send()is called on the main thread.3. Download Completion Handling
4. Subtitle File Deletion
localSubtitleURLisnilor missing:.vtt,.srt,.webvtt) in the persistent directory.5. General Cleanup
UserDefaultsusage remains for downloads.