Fix SHELL=/bin/sh=dash support #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "." command is more portable as it is defined in POSIX[0], whereas the "source" command is a bash (and some other shells) extensions. In particular, "source" is not supported by dash, the default /bin/sh on Debian 12. [0]: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/V3_chap02.html#dot Signed-off-by: Yoann Congal <[email protected]>
ycongal-smile
force-pushed
the
yco/source_dot
branch
from
5d99a3d to
5aa0558
Compare
Dash does not support passing arguments to the "." command. The default poky ./oe-init-build-env has this comment: # Normally this is called as '. ./oe-init-build-env <builddir>' # # This works in most shells (not dash), but not all of them pass the arguments # when being sourced. To workaround the shell limitation use "set <builddir>" # prior to sourcing this script. Implement the "set" workaround for dash support. Also, change current working directory to match oe-init-build-env expectation of being sourced from its base directory in dash. Signed-off-by: Yoann Congal <[email protected]>
ycongal-smile
force-pushed
the
yco/source_dot
branch
from
5aa0558 to
f797efd
Compare
Contributor
Author
|
Updated to clear CI checks: changed expected test output and formatting with |
Owner
|
Thanks Yoann. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cooker shellis called from dash withSHELL=/bin/sh, it fails with(not that dash may not reset SHELL and if SHELL contains a more "nicer" SHELL (e.g. bash), cooker will use that and avoid the limitation of dash)
=> Use "." instead of "source". This is the first commit.
After that fix, the sourcing of
oe-init-build-envmust be adapted to the fact that dash does not handle arguments to the "." command.=> Use the
set <builddir>workaround given inoe-init-build-env. This is the second commit.