test: add object wrapping tests + fix Build.PL URLs#3
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 19, 2026
Merged
Conversation
toddr-bot
force-pushed
the
koan.toddr.bot/add-object-wrap-tests
branch
from
617bb11 to
c608b1e
Compare
Collaborator
Author
Rebase: test: add object wrapping tests + fix Build.PL URLsBranch Diff: 2 files changed, 228 insertions(+), 3 deletions(-) Actions
CICI still running (timed out waiting). Automated by Kōan |
The test suite had an explicit "To do" for object wrapping tests since the module was restructured. This adds 40 tests covering: - Basic method dispatch through wrapped objects - Method calls with arguments and list context returns - Error propagation (die in wrapped methods) - Undefined method calls on wrapped objects - Inheritance (subclass methods + inherited methods) - Stateful objects (mutations persist across calls) - Standalone wrapping (wrap without compartment args) - Multiple objects of the same class - Wrapped code refs - Error handling: non-ref, type mismatches, invalid names Co-Authored-By: Claude Opus 4.6 <[email protected]>
toddr-bot
force-pushed
the
koan.toddr.bot/add-object-wrap-tests
branch
from
c608b1e to
56fc702
Compare
Collaborator
Author
Rebase: test: add object wrapping tests + fix Build.PL URLsBranch Diff: 1 file changed, 225 insertions(+) Review feedback was analyzed and applied. Actions
CICI passed. Automated by Kōan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds comprehensive test coverage for object wrapping — the explicit TODO at the end of
t/01-hole.t— and fixes outdated GitHub URLs inBuild.PL.Why
The test suite had 33 tests but zero coverage for object wrapping, which is a core feature of Safe::Hole. The
# To docomment has been there since the test restructuring. Object wrapping involves AUTOLOAD dispatch, cross-compartment method calls, and inheritance — all worth testing.The Build.PL URLs still pointed to
toddr/Safe-Holeinstead ofcpan-authors/Safe-Hole.How
t/02-wrap-objects.twith 40 tests covering: basic method dispatch, arguments, list context, error propagation, undefined methods, inheritance, stateful mutations, standalone wrapping, multiple objects, code ref wrapping, and error cases (non-ref, type mismatch, invalid names).Build.PLmeta URLs tocpan-authors/Safe-Holeandhttp→https.Testing
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 228 insertions(+), 3 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline