fix: Convert from Build.PL to Makefile.PL#10
Merged
toddr merged 2 commits intocpan-authors:mainfrom Mar 18, 2026
Merged
Conversation
toddr
approved these changes
Mar 18, 2026
Member
|
I think you missed labeling this Makefile.PL as supporting an XS module do we need to move the XS file to the base directory? |
Replace Module::Build with ExtUtils::MakeMaker as the build system. - Add Makefile.PL with equivalent configuration - Remove Build.PL - Update CI workflow to use `perl Makefile.PL && make && make test` - Update MANIFEST to reference Makefile.PL instead of Build.PL - Update MANIFEST.SKIP for MakeMaker artifacts - Remove Module::Build dependency from cpanfile Fixes cpan-authors#8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toddr-bot
force-pushed
the
koan.toddr.bot/fix-issue-8
branch
from
2cc2321 to
3f2d6d6
Compare
Collaborator
Author
Rebase: fix: Convert from Build.PL to Makefile.PLBranch Diff: 7 files changed, 63 insertions(+), 52 deletions(-) Review feedback was analyzed and applied. Actions
CICI passed. Automated by Kōan |
toddr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Module::Build (
Build.PL) with ExtUtils::MakeMaker (Makefile.PL) as the build system for Safe::Hole.Fixes #8
Changes
Makefile.PLwith equivalent configuration (metadata, test deps, resources)Build.PLperl Makefile.PL && make && make test(andgmakeon Windows)MANIFESTto referenceMakefile.PLinstead ofBuild.PLMANIFEST.SKIPfor MakeMaker build artifactsModule::Builddependency fromcpanfileTest plan
perl Makefile.PL && make && make test— all 4 test files pass (36 tests)make disttest— passes successfullyGenerated by Kōan /fix
Quality Report
Changes: 6 files changed, 62 insertions(+), 51 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline