fix: add missing --listen option to Options()#24
Merged
Conversation
The listen backlog value was used in Bind() but never exposed as a command-line option, making it impossible to override the default of 10. Fixes #4 Co-Authored-By: Claude Opus 4.6 <[email protected]>
b3b2bc3 to
e31090a
Compare
Author
Rebase: fix: add missing --listen option to Options()Branch Diff: 3 files changed, 26 insertions(+) Actions
CICI passed. Automated by Kōan |
toddr
approved these changes
Mar 22, 2026
toddr
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
listenbacklog value was used inBind()for both TCP and Unix sockets but was never exposed as a command-line option inOptions(), making it impossible to override the default value of 10.Fixes #4
Changes
--listen <num>option (integer) toOptions()inNet::Daemont/listen.ttest verifying the option exists and values are passed throught/listen.ttoMANIFESTTest plan
t/listen.tverifies the option is present, has the correct template, and that--listen 20stores the value on the objectGenerated by Kōan /fix
Quality Report
Changes: 3 files changed, 26 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline