Skip to content

fix: always select ID in GetAll pagination to prevent infinite loop #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: always select ID in GetAll pagination to prevent infinite loop #2497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39d8016
fix: always select ID in GetAll pagination to prevent infinite loop
Nov 20, 2025
5463264
fix: always select ID in GetAll and respect opt fields
Nov 20, 2025
1bf3d31
fix: always include ID in getSelected for all DAOs to support paginat…
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions backend/domain/app/internal/dal/app_release_record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,9 @@ func (r *APPReleaseRecordDAO) getSelected(opt *APPSelectedOption) (selected []fi
}

table := r.query.AppReleaseRecord
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.PublishRecordID {
selected = append(selected, table.ID)
}
if opt.APPID {
selected = append(selected, table.AppID)
}
Expand Down
2 changes: 2 additions & 0 deletions backend/domain/plugin/internal/dal/agent_tool_draft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ func (at *AgentToolDraftDAO) getSelected(opt *ToolSelectedOption) (selected []fi
}

table := at.query.AgentToolDraft
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.ToolID {
selected = append(selected, table.ToolID)
Expand Down
5 changes: 2 additions & 3 deletions backend/domain/plugin/internal/dal/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,9 @@ func (p *PluginDAO) getSelected(opt *PluginSelectedOption) (selected []field.Exp
}

table := p.query.Plugin
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.PluginID {
selected = append(selected, table.ID)
}
if opt.OpenapiDoc {
selected = append(selected, table.OpenapiDoc)
}
Expand Down
5 changes: 2 additions & 3 deletions backend/domain/plugin/internal/dal/plugin_draft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,9 @@ func (p *PluginDraftDAO) getSelected(opt *PluginSelectedOption) (selected []fiel
}

table := p.query.PluginDraft
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.PluginID {
selected = append(selected, table.ID)
}
if opt.OpenapiDoc {
selected = append(selected, table.OpenapiDoc)
}
Expand Down
2 changes: 2 additions & 0 deletions backend/domain/plugin/internal/dal/plugin_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ func (p *PluginVersionDAO) getSelected(opt *PluginSelectedOption) (selected []fi
}

table := p.query.PluginVersion
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.PluginID {
selected = append(selected, table.PluginID)
Expand Down
7 changes: 3 additions & 4 deletions backend/domain/plugin/internal/dal/tool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ func (t *ToolDAO) getSelected(opt *ToolSelectedOption) (selected []field.Expr) {
}

table := t.query.Tool

if opt.ToolID {
selected = append(selected, table.ID)
}
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.ActivatedStatus {
selected = append(selected, table.ActivatedStatus)
}
Expand Down
5 changes: 2 additions & 3 deletions backend/domain/plugin/internal/dal/tool_draft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,9 @@ func (t *ToolDraftDAO) getSelected(opt *ToolSelectedOption) (selected []field.Ex
}

table := t.query.ToolDraft
// Always include ID, it may be used as cursor in pagination loops
selected = append(selected, table.ID)

if opt.ToolID {
selected = append(selected, table.ID)
}
if opt.ActivatedStatus {
selected = append(selected, table.ActivatedStatus)
}
Expand Down