Move state overrides into ethcontract#3671
Merged
MartinquaXD merged 4 commits intomainfrom Sep 19, 2025
Merged
Conversation
jmg-duarte
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the code base to make use of
.call_with_state_overridesthat was introduced in cowprotocol/ethcontract-rs#983.Changes
StateOverridestypes from our code base because they are now in ethcontract-rsArc<dyn CodeSimulating>withWeb3.call_with_state_overridesinstead of weird extension trait on web3<module>.rsto<module>/mod.rsto be more consistent with the remaining code baseHow to test
tests of balance overriding logic should still work