Negative coverage when integer overflows#1267
Merged
MarcoRossignoli merged 2 commits intocoverlet-coverage:masterfrom Dec 20, 2021
Merged
Negative coverage when integer overflows#1267MarcoRossignoli merged 2 commits intocoverlet-coverage:masterfrom
MarcoRossignoli merged 2 commits intocoverlet-coverage:masterfrom
Conversation
daveMueller
force-pushed
the
1266_IntegerOverflow
branch
from
bdd766a to
db6bb02
Compare
Collaborator
Author
|
I'm not so sure about the test. The loop to |
petli
reviewed
Dec 15, 2021
petli
reviewed
Dec 15, 2021
Collaborator
petli
left a comment
petli
left a comment
There was a problem hiding this comment.
I agree the test seems overkill. The interesting logic is in the collection of the hit results, can that be tested by a unit test that just reads negative hits, rather than a full integration test?
Collaborator
|
I have deleted two review comments (and updated the third) as I realised I did my sums wrong and the situation I was thinking about couldn't happen. |
Collaborator
Author
|
Thanks @petli. I will try to somehow mock a |
Collaborator
|
Thanks to all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1266