Skip to content

Union resolution results in an extra level of nesting #150

@jnwng

Description

@jnwng

in a query like this:

query ($bundleName: String!) {
  RapidashAppsV1Resource {
    bundleName(bundleName: $bundleName, limit: 1) {
      elements {
        deploys: deployIds(limit: 10) {
          elements {
            id
            buildId {
              buildDetails {
                ... on org_coursera_rapidash_ProductionBuildDetailsMember {
          -->  org_coursera_rapidash_ProductionBuildDetails {
                    commitId {
                      summary
                      message
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}

the nested field org_coursera_rapidash_ProductionBuildDetails is unnecessary since we've already subselected the particular union type via the inline fragment. at this point, we should have resolved the RapidashBuildDetails. ideally this should look like:

buildDetails {
  ... on org_coursera_rapidash_ProductionBuildDetailsMember {
    commitId {
      summary
      message
    }
  }
}

or (stretch goal) renaming the union as well.

buildDetails {
  ... on productionBuildDetails {
    commitId {
      summary
      message
    }
  }
}

/cc @bryan-coursera

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions