imp!: removed 'ConsensusHost' interface #6937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* imp: removed ValidateSelfClient * docs: updated a godoc
srdtrk
requested review from
AdityaSripal,
DimitrisJim,
bznein,
chatton,
colin-axner,
crodriguezvega,
damiannolan and
gjermundgaraba
as code owners
srdtrk
added
03-connection
02-client
protobuf
colin-axner
reviewed
Jul 29, 2024
colin-axner
reviewed
Jul 30, 2024
colin-axner
approved these changes
Jul 30, 2024
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Wooo! Super excited with all these red diffs. So nice to see a reduction in complexity!! Thanks for ripping this out @srdtrk and thank you @crodriguezvega for the docs!
I think it might be nice to keep an eye on code cov here. I think I found 1 small unit tests which should be added back, and I'm wondering it might be hard to catch others accidentally removed like this
| // generate a new connection | ||
| connectionID := k.GenerateConnectionIdentifier(ctx) | ||
|
|
||
| // check that the consensus height the counterparty chain is using to store a representation |
Contributor
There was a problem hiding this comment.
these diffs are the ones we will backport
Comment on lines
-109
to
-111
| if msg.PreviousConnectionId != "" { | ||
| return errorsmod.Wrap(ErrInvalidConnectionIdentifier, "previous connection identifier must be empty, this field has been deprecated as crossing hellos are no longer supported") | ||
| } |
Contributor
There was a problem hiding this comment.
opened #6987 as I feel we should just reserve this field now
DimitrisJim
approved these changes
Aug 1, 2024
Contributor
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
lovely to see this, great trimming! I also noticed we have the Staking keeper interface still in 02-client's expected keeper's, might as well drop that too.
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: colin axnér <[email protected]>
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
* imp(02-client,03-connection)!: remove `ValidateSelfClient` (#6853) * imp: removed ValidateSelfClient * docs: updated a godoc * imp: deleted consensus host from core * imp(08-wasm): removed consensus host * imp: fix linter * imp: fixed linter * imp: fixed simapp * imp: updated docs * imp: removed more code * revert * imp: removed unneeded proto fields * imp: lint * lint * imp: auto generated code * imp: removed conflicts * imp: removed more code * fix: tests * feat: all tests passing * fix: added the reserved proto fields back with deprecation notice * style: linted * imp: regenerated proto * imp: review item * revert: conn name change * docs: added changelog * add godoc string of QueryConnectionHandshakeProof * add migration docs for ibc-go * Update CHANGELOG.md * update changelog * imp(proto): added deprecation notice to field * imp: ran 'make proto-all' * imp: removed unused keeper * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> * Update docs/docs/05-migrations/13-v8-to-v9.md Co-authored-by: colin axnér <[email protected]> * Update docs/docs/05-migrations/13-v8-to-v9.md Co-authored-by: colin axnér <[email protected]> --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 2028e9a) # Conflicts: # CHANGELOG.md # docs/docs/01-ibc/02-integration.md # docs/docs/05-migrations/13-v8-to-v9.md # modules/core/02-client/keeper/keeper.go # modules/core/keeper/keeper.go # modules/light-clients/08-wasm/CHANGELOG.md
10 tasks
DimitrisJim
pushed a commit
that referenced
this pull request
Aug 7, 2024
* imp!: removed 'ConsensusHost' interface (#6937) * imp(02-client,03-connection)!: remove `ValidateSelfClient` (#6853) * imp: removed ValidateSelfClient * docs: updated a godoc * imp: deleted consensus host from core * imp(08-wasm): removed consensus host * imp: fix linter * imp: fixed linter * imp: fixed simapp * imp: updated docs * imp: removed more code * revert * imp: removed unneeded proto fields * imp: lint * lint * imp: auto generated code * imp: removed conflicts * imp: removed more code * fix: tests * feat: all tests passing * fix: added the reserved proto fields back with deprecation notice * style: linted * imp: regenerated proto * imp: review item * revert: conn name change * docs: added changelog * add godoc string of QueryConnectionHandshakeProof * add migration docs for ibc-go * Update CHANGELOG.md * update changelog * imp(proto): added deprecation notice to field * imp: ran 'make proto-all' * imp: removed unused keeper * Update CHANGELOG.md Co-authored-by: colin axnér <[email protected]> * Update docs/docs/05-migrations/13-v8-to-v9.md Co-authored-by: colin axnér <[email protected]> * Update docs/docs/05-migrations/13-v8-to-v9.md Co-authored-by: colin axnér <[email protected]> --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 2028e9a) # Conflicts: # CHANGELOG.md # docs/docs/01-ibc/02-integration.md # docs/docs/05-migrations/13-v8-to-v9.md # modules/core/02-client/keeper/keeper.go # modules/core/keeper/keeper.go # modules/light-clients/08-wasm/CHANGELOG.md * fix merge conflicts, changelog, delete docs, keeper fns --------- Co-authored-by: srdtrk <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.