Skip to content

add missing query flags to client status query cli #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crodriguezvega merged 5 commits into from
Sep 12, 2022
Merged

add missing query flags to client status query cli #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b2de3c
add missing tx and query flags to cli
crodriguezvega Sep 8, 2022
32546dc
run gofumpt
crodriguezvega Sep 8, 2022
5e9fb9b
remove adding tx flags
crodriguezvega Sep 9, 2022
d36e1ca
Merge branch 'main' into carlos/add-missing-tx-query-flags
crodriguezvega Sep 9, 2022
bba0aca
Merge branch 'main' into carlos/add-missing-tx-query-flags
crodriguezvega Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/core/02-client/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ func GetCmdQueryClientStatus() *cobra.Command {
},
}

flags.AddQueryFlagsToCmd(cmd)

return cmd
}

Expand Down
2 changes: 0 additions & 2 deletions modules/core/02-client/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ func NewCreateClientCmd() *cobra.Command {
}

flags.AddTxFlagsToCmd(cmd)

Copy link
Contributor

@chatton chatton Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] unnecessary changes to this file

Copy link
Contributor Author

@crodriguezvega crodriguezvega Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other commands in the same file had that statement next to the return, so I removed that empty line for consistency. I can revert it, if you want; have no strong preference...

Copy link
Contributor

@chatton chatton Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay, no it's not a big deal at all!

Copy link
Contributor

@colin-axner colin-axner Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually kinda like the spaces, a little confusing why we format differently between query.go and tx.go

return cmd
}

Expand Down Expand Up @@ -238,7 +237,6 @@ func NewUpgradeClientCmd() *cobra.Command {
}

flags.AddTxFlagsToCmd(cmd)

return cmd
}

Expand Down