chore: adding sdk.Msg impl for ics27 MsgRegisterAccount#2081
Merged
damiannolan merged 13 commits intomainfrom Aug 24, 2022
Merged
chore: adding sdk.Msg impl for ics27 MsgRegisterAccount#2081damiannolan merged 13 commits intomainfrom
sdk.Msg impl for ics27 MsgRegisterAccount#2081damiannolan merged 13 commits intomainfrom
Conversation
…nterfaces and boilerplate
…cosmos/ibc-go into damian/2051-add-register-account-protos
…hub.com:cosmos/ibc-go into damian/2053-impl-sdk-msg-interface-register-acc
damiannolan
requested review from
AdityaSripal,
colin-axner and
seantking
as code owners
charleenfei
approved these changes
Aug 24, 2022
Contributor
charleenfei
left a comment
charleenfei
left a comment
There was a problem hiding this comment.
nit comment but otherwise LGTM!!
| ) | ||
|
|
||
| var ( | ||
| testAccAddress = "cosmos17dtl0mjt3t77kpuhg2edqzjpszulwhgzuj9ljs" |
Contributor
There was a problem hiding this comment.
super nit but maybe we can add this a const file?
Contributor
Author
There was a problem hiding this comment.
I've added TestAccAddress to testing/values.go
charleenfei
reviewed
Aug 24, 2022
|
|
||
| if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner) | ||
| } |
Contributor
There was a problem hiding this comment.
do we also need a validation on the version?
Contributor
There was a problem hiding this comment.
I don't think we can since this version may be wrapped with many different versions (ics29 and so forth). There's no guarantee that the provided version is an ics27 version at the top level
colin-axner
approved these changes
Aug 24, 2022
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Do we have a changelog entry already for adding this message type?
|
|
||
| if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner) | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think we can since this version may be wrapped with many different versions (ics29 and so forth). There's no guarantee that the provided version is an ics27 version at the top level
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
+ Coverage 79.94% 80.03% +0.08%
==========================================
Files 170 170
Lines 11801 11813 +12
==========================================
+ Hits 9434 9454 +20
+ Misses 1950 1941 -9
- Partials 417 418 +1
|
damiannolan
deleted the
damian/2053-impl-sdk-msg-interface-register-acc
branch
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
* adding new controller msg service, register account types, register interfaces and boilerplate * fixing typo * fixing protodoc and regenerate godocs * adding channel id to MsgRegisterAccountResponse * adding sdk.Msg impl for MsgRegisterAccount * formatting imports * adding additional tests with multiple versions, creating TestAccAddress const (cherry picked from commit 94d0840) # Conflicts: # modules/apps/27-interchain-accounts/controller/types/msgs.go # testing/values.go
damiannolan
added a commit
that referenced
this pull request
Aug 25, 2022
…2108) * adding new controller msg service, register account types, register interfaces and boilerplate * fixing typo * fixing protodoc and regenerate godocs * adding channel id to MsgRegisterAccountResponse * adding sdk.Msg impl for MsgRegisterAccount * formatting imports * adding additional tests with multiple versions, creating TestAccAddress const (cherry picked from commit 94d0840) # Conflicts: # modules/apps/27-interchain-accounts/controller/types/msgs.go # testing/values.go Co-authored-by: Damian Nolan <damiannolan@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sdk.MsginterfaceValidateBasicGetSignerscloses: #2053
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes