Skip to content

fix: "acknowledgement written" logs unsupported type #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colin-axner merged 7 commits into from
Aug 10, 2022
Merged

fix: "acknowledgement written" logs unsupported type #1919

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d2748b5
fix: "acknowledgement written" logs unsupported type
joeabbey Aug 8, 2022
6e377c0
Merge branch 'main' into joeabbey/fix-acknowledgement-written-logs
crodriguezvega Aug 9, 2022
790a922
Updating CHANGELOG.md
joeabbey Aug 9, 2022
8a57971
Merge branch 'joeabbey/fix-acknowledgement-written-logs' of github.co…
joeabbey Aug 9, 2022
eec0703
Merge branch 'main' into joeabbey/fix-acknowledgement-written-logs
joeabbey Aug 9, 2022
cd21145
Merge branch 'main' into joeabbey/fix-acknowledgement-written-logs
colin-axner Aug 10, 2022
3cfe017
Merge branch 'main' into joeabbey/fix-acknowledgement-written-logs
colin-axner Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/core/04-channel/keeper/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func (k Keeper) WriteAcknowledgement(
// log that a packet acknowledgement has been written
k.Logger(ctx).Info(
"acknowledgement written",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down