Skip to content

feat: emitting an event when handling a client upgrade proposal (backport #1570)#1766

Merged
crodriguezvega merged 5 commits intorelease/v2.4.xfrom
mergify/bp/release/v2.4.x/pr-1570
Jul 22, 2022
Merged

feat: emitting an event when handling a client upgrade proposal (backport #1570)#1766
crodriguezvega merged 5 commits intorelease/v2.4.xfrom
mergify/bp/release/v2.4.x/pr-1570

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 21, 2022

This is an automatic backport of pull request #1570 done by Mergify.
Cherry-pick of 8422d0c has failed:

On branch mergify/bp/release/v2.4.x/pr-1570
Your branch is up to date with 'origin/release/v2.4.x'.

You are currently cherry-picking commit 8422d0c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/02-client/keeper/proposal.go
	modified:   modules/core/02-client/types/events.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	deleted by us:   modules/core/02-client/keeper/events.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* feat: emitting an event when handling a client upgrade proposal

* refactor: only emit event if err is nil

* refactor: idiotmatic go:

(cherry picked from commit 8422d0c)

# Conflicts:
#	CHANGELOG.md
#	modules/core/02-client/keeper/events.go
@crodriguezvega crodriguezvega merged commit bb3d1cf into release/v2.4.x Jul 22, 2022
@crodriguezvega crodriguezvega deleted the mergify/bp/release/v2.4.x/pr-1570 branch July 22, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants