feat: implement registered payee fee distribution#1526
Merged
damiannolan merged 17 commits intomainfrom Jun 17, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
+ Coverage 80.24% 80.29% +0.05%
==========================================
Files 166 166
Lines 12252 12304 +52
==========================================
+ Hits 9832 9880 +48
- Misses 1956 1959 +3
- Partials 464 465 +1
|
…:cosmos/ibc-go into damian/1477-implement-payee-distribution
damiannolan
requested review from
AdityaSripal,
charleenfei,
colin-axner and
seantking
as code owners
chatton
reviewed
Jun 13, 2022
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
Great test coverage! Just a small question, nice work 🥇
charleenfei
reviewed
Jun 15, 2022
crodriguezvega
approved these changes
Jun 17, 2022
Contributor
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Superb work, @damiannolan, with the new payee feature and the refactor of the counterparty address. 🎸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OnAcknowledgementPacketOnTimeoutPacketexpResultand additional cases (registered payees, application cb failure)closes: #1477
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes