chore: adding basic Msg service and RegisterAccount rpc boilerplate#2068
chore: adding basic Msg service and RegisterAccount rpc boilerplate#2068damiannolan merged 7 commits intomainfrom
Msg service and RegisterAccount rpc boilerplate#2068Conversation
…nterfaces and boilerplate
proto/ibc/applications/interchain_accounts/controller/v1/tx.proto
Outdated
Show resolved
Hide resolved
damiannolan
requested review from
AdityaSripal,
charleenfei,
chatton,
colin-axner,
crodriguezvega and
seantking
as code owners
| } | ||
|
|
||
| // MsgRegisterAccountResponse defines the response for Msg/RegisterAccount | ||
| message MsgRegisterAccountResponse {} |
There was a problem hiding this comment.
Is it useful to return the portID? I guess not since the generation of the portID is stateless?
The channelID would be useful? Actual implementation of that could be in a followup pr
There was a problem hiding this comment.
I think If we're going to add the channelID we may need to break the RegisterInterchainAccount API to return it?
That is, depending on how we approach this...
I'm just thinking it would be need to be retrieved from the MsgChannelOpenInitResponse from sdk.Result.MsgResponses[0]: https://github.com/cosmos/ibc-go/blob/main/modules/apps/27-interchain-accounts/controller/keeper/account.go#L44
What do you think?
There was a problem hiding this comment.
Why do we need to break the RegisterInterchainAccount API?
I was thinking we would make a private function registerInterchainAccount (with a slightly diff name) which both RegisterInterchainAccount and the rpc RegisterAccount call into, that way we can add more info to the API
There was a problem hiding this comment.
Great point! That sounds good to me! :)
…cosmos/ibc-go into damian/2051-add-register-account-protos
…te (#2068) (#2109) * adding new controller msg service, register account types, register interfaces and boilerplate * fixing typo * fixing protodoc and regenerate godocs * adding channel id to MsgRegisterAccountResponse (cherry picked from commit 5765fe7) Co-authored-by: Damian Nolan <[email protected]>
4 participants
Description
Msgservice to interchain accounts controllerRegisterAccountprotobuf types and rpccloses: #2051
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes