Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

Context

close: #966

Summary by CodeRabbit

  • New Features

    • Introduced a new API to close the pruning process when the node database is closed, enhancing resource management and system stability.
  • Bug Fixes

    • Improved cancellation handling during the pruning process to prevent memory leaks and ensure graceful termination of operations.
  • Tests

    • Added a test to verify the closure functionality of the NodeDB instance, ensuring it can close without errors.

This is an automatic backport of pull request #970 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team July 26, 2024 18:23
@coderabbitai
Copy link

coderabbitai bot commented Jul 26, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

@cool-develope cool-develope merged commit e69b1cd into release/v1.2.x Jul 26, 2024
@cool-develope cool-develope deleted the mergify/bp/release/v1.2.x/pr-970 branch July 26, 2024 19:05
@yihuang
Copy link

yihuang commented Nov 5, 2024

we should tag 1.2.1 for this bug fix I think, and update it in cosmos-sdk 0.50.x branch. @cool-develope @tac0turtle

@tac0turtle
Copy link
Contributor

on it,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants