REVIEW: baseapp: start TestInfo

[zramsay]

No description provided.

[codecov]

Codecov Report

Merging #488 into develop will increase coverage by 2.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    53.89%   56.03%   +2.14%     
===========================================
  Files           27       27              
  Lines         1542     1542              
===========================================
+ Hits           831      864      +33     
+ Misses         660      625      -35     
- Partials        51       53       +2

[adrianbrink]

LGTM

[jbibla]

surely, someone can merge this.

@rigelrozanski ? @ethanfrey ? @adrianbrink ?

[ethanfrey]

Good tests in general.
I wonder about glide.lock (see comment).

Also, while we test messages, we have no meaningful unit tests for handler. That would be very good to add (but can be a separate PR). For an example, see:
https://github.com/tendermint/clearchain/blob/master/types/handler_test.go#L105-L171

[ethanfrey]

Why do we have this glide.lock here?
Isn't it better just to use the glide.lock in the root directory.
It makes it very hard to upgrade and test code with basecoin otherwise, especially as the repo is in a large state of flux now.

[ethanfrey]

@jolesbi Only Jae and Bucky can merge on this repo.
https://github.com/cosmos/cosmos-sdk/blob/master/CODEOWNERS