Unit tests #37
Merged
Unit tests #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squash me squash me squash
ebuchman
suggested changes
Feb 19, 2017
Contributor
ebuchman
left a comment
ebuchman
left a comment
There was a problem hiding this comment.
Looks good. Main thing is to try and use more table driven testing
state/state_test.go
Outdated
| } | ||
|
|
||
| setRecords(s) | ||
| assert.True(t, bytes.Equal(s.Get([]byte("foo")), []byte("snake")), "state doesn't retrieve after Set") |
Contributor
There was a problem hiding this comment.
would love to see a more table driven approach for a lot of these tests: https://dave.cheney.net/2013/06/09/writing-table-driven-tests-in-go
types/account_test.go
Outdated
| accCopy.Sequence = 1 | ||
| t.Log(acc.Sequence) | ||
| t.Log(accCopy.Sequence) | ||
| assert.True(t, acc.Sequence != accCopy.Sequence, "Account Copy Error") |
Contributor
There was a problem hiding this comment.
why not check the accounts are equal?
Contributor
Author
There was a problem hiding this comment.
okay switched. was confused because the pointer wasn't equal but that makes sense, not supposed to be.
rigelrozanski
force-pushed
the
unitTests
branch
from
a10d474 to
e6579cf
Compare
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Jun 26, 2018
Nano Support
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Feb 13, 2022
* Execute validator unbonding at consensus changeover * Fix producing block status of genesis validators * Add comments
inon-man
pushed a commit
to classic-terra/cosmos-sdk
that referenced
this pull request
Feb 21, 2023
…ns/actions/cache-3.0.1 chore(deps): bump actions/cache from 2.1.6 to 3.0.1
sainoe
pushed a commit
to informalsystems/cosmos-sdk
that referenced
this pull request
Apr 25, 2025
Implement anti-spam mechanism for proposals in gov
tbruyelle
pushed a commit
to tbruyelle/cosmos-sdk
that referenced
this pull request
Dec 16, 2025
* refactor(x/gov): use interface checks instead of type checks * low cost make lint fix 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this is branched from queryReg which is in the PR, should merge after PR #26