-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(server): reject overlapping historical gRPC block ranges #25807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aljo242
merged 11 commits into
cosmos:main
from
songgaoye:fix_server_overlapping_historical
Jan 29, 2026
Merged
fix(server): reject overlapping historical gRPC block ranges #25807
aljo242
merged 11 commits into
cosmos:main
from
songgaoye:fix_server_overlapping_historical
Jan 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
reviewed
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25807 +/- ##
==========================================
+ Coverage 68.16% 68.24% +0.08%
==========================================
Files 910 894 -16
Lines 59051 58158 -893
==========================================
- Hits 40250 39688 -562
+ Misses 18801 18470 -331
🚀 New features to boost your workflow:
|
Contributor
|
ci failing |
aljo242
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Historical gRPC routing iterates over a map with random iteration order.
Overlapping block ranges cause nondeterministic backend selection across
runs. Added validation in GetConfig to detect and reject overlapping
ranges at parse time with clear error messages.