feat(bank/v2): port tokenfactory into bank/v2

simapp/go.mod

@@ -14,7 +14,7 @@ require (
 	cosmossdk.io/math v1.3.0
 	cosmossdk.io/store v1.1.1
 	cosmossdk.io/tools/confix v0.0.0-20230613133644-0a778132a60f
-	cosmossdk.io/x/accounts v0.0.0-20240913065641-0064ccbce64e
+	cosmossdk.io/x/accounts v0.0.0-20241112091912-96a1c1c833ea
 	cosmossdk.io/x/accounts/defaults/base v0.0.0-00010101000000-000000000000
 	cosmossdk.io/x/accounts/defaults/lockup v0.0.0-20240417181816-5e7aae0db1f5
 	cosmossdk.io/x/accounts/defaults/multisig v0.0.0-00010101000000-000000000000
@@ -63,6 +63,7 @@ require (
 	cloud.google.com/go/storage v1.43.0 // indirect
 	cosmossdk.io/errors v1.0.1 // indirect
 	cosmossdk.io/schema v0.3.1-0.20241010135032-192601639cac // indirect
+	cosmossdk.io/x/accounts/defaults/admin v0.0.0-00010101000000-000000000000 // indirect
 	filippo.io/edwards25519 v1.1.0 // indirect
 	github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
 	github.com/99designs/keyring v1.2.2 // indirect
@@ -257,6 +258,7 @@ replace (
 	cosmossdk.io/store => ../store
 	cosmossdk.io/tools/confix => ../tools/confix
 	cosmossdk.io/x/accounts => ../x/accounts
+	cosmossdk.io/x/accounts/defaults/admin => ../x/accounts/defaults/admin
 	cosmossdk.io/x/accounts/defaults/base => ../x/accounts/defaults/base
 	cosmossdk.io/x/accounts/defaults/lockup => ../x/accounts/defaults/lockup
 	cosmossdk.io/x/accounts/defaults/multisig => ../x/accounts/defaults/multisig

simapp/v2/go.mod

@@ -14,7 +14,7 @@ require (
 	cosmossdk.io/server/v2/cometbft v0.0.0-20241015140036-ee3d320eaa55
 	cosmossdk.io/store/v2 v2.0.0
 	cosmossdk.io/tools/confix v0.0.0-00010101000000-000000000000
-	cosmossdk.io/x/accounts v0.0.0-20240913065641-0064ccbce64e
+	cosmossdk.io/x/accounts v0.0.0-20241112091912-96a1c1c833ea
 	cosmossdk.io/x/authz v0.0.0-00010101000000-000000000000
 	cosmossdk.io/x/bank v0.0.0-20240226161501-23359a0b6d91
 	cosmossdk.io/x/circuit v0.0.0-20230613133644-0a778132a60f
@@ -65,6 +65,7 @@ require (
 	cosmossdk.io/server/v2/appmanager v0.0.0-20240802110823-cffeedff643d // indirect
 	cosmossdk.io/server/v2/stf v0.0.0-20240708142107-25e99c54bac1 // indirect
 	cosmossdk.io/store v1.1.1 // indirect
+	cosmossdk.io/x/accounts/defaults/admin v0.0.0-00010101000000-000000000000 // indirect
 	cosmossdk.io/x/tx v1.0.0-alpha.1 // indirect
 	filippo.io/edwards25519 v1.1.0 // indirect
 	github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
@@ -259,6 +260,7 @@ replace (
 	cosmossdk.io/collections => ../../collections
 	cosmossdk.io/tools/confix => ../../tools/confix
 	cosmossdk.io/x/accounts => ../../x/accounts
+	cosmossdk.io/x/accounts/defaults/admin => ../../x/accounts/defaults/admin
 	cosmossdk.io/x/accounts/defaults/base => ../../x/accounts/defaults/base
 	cosmossdk.io/x/accounts/defaults/lockup => ../../x/accounts/defaults/lockup
 	cosmossdk.io/x/accounts/defaults/multisig => ../../x/accounts/defaults/multisig

tests/go.mod

@@ -36,7 +36,7 @@ require (
 	cosmossdk.io/runtime/v2 v2.0.0-20240911143651-72620a577660
 	cosmossdk.io/server/v2/stf v0.0.0-00010101000000-000000000000
 	cosmossdk.io/store/v2 v2.0.0-00010101000000-000000000000
-	cosmossdk.io/x/accounts v0.0.0-20240913065641-0064ccbce64e
+	cosmossdk.io/x/accounts v0.0.0-20241112091912-96a1c1c833ea
 	cosmossdk.io/x/accounts/defaults/base v0.0.0-00010101000000-000000000000
 	cosmossdk.io/x/accounts/defaults/lockup v0.0.0-20240417181816-5e7aae0db1f5
 	cosmossdk.io/x/accounts/defaults/multisig v0.0.0-00010101000000-000000000000
@@ -73,6 +73,7 @@ require (
 	cosmossdk.io/indexer/postgres v0.1.0 // indirect
 	cosmossdk.io/schema v0.3.1-0.20241010135032-192601639cac // indirect
 	cosmossdk.io/server/v2/appmanager v0.0.0-00010101000000-000000000000 // indirect
+	cosmossdk.io/x/accounts/defaults/admin v0.0.0-00010101000000-000000000000 // indirect
 	cosmossdk.io/x/circuit v0.0.0-20230613133644-0a778132a60f // indirect
 	cosmossdk.io/x/epochs v0.0.0-20240522060652-a1ae4c3e0337 // indirect
 	filippo.io/edwards25519 v1.1.0 // indirect
@@ -263,6 +264,7 @@ replace (
 	cosmossdk.io/store => ../store
 	cosmossdk.io/store/v2 => ../store/v2
 	cosmossdk.io/x/accounts => ../x/accounts
+	cosmossdk.io/x/accounts/defaults/admin => ../x/accounts/defaults/admin
 	cosmossdk.io/x/accounts/defaults/base => ../x/accounts/defaults/base
 	cosmossdk.io/x/accounts/defaults/lockup => ../x/accounts/defaults/lockup
 	cosmossdk.io/x/accounts/defaults/multisig => ../x/accounts/defaults/multisig

tests/systemtests/bankv2_test.go

@@ -5,7 +5,9 @@ package systemtests
 import (
 	"fmt"
 	"testing"
+	"time"
 
+	"cosmossdk.io/math"
 	"github.com/stretchr/testify/require"
 	"github.com/tidwall/gjson"
 )
@@ -56,3 +58,278 @@ func TestBankV2SendTxCmd(t *testing.T) {
 	receiverBalance := gjson.Get(receiverRaw, "balance.amount").Int()
 	require.Equal(t, receiverBalance, transferAmount)
 }
+
+func TestCreateDenom(t *testing.T) {
+	// Currently only run with app v2
+	if !isV2() {
+		t.Skip()
+	}
+	// given a running chain
+
+	sut.ResetChain(t)
+	cli := NewCLIWrapper(t, sut, verbose)
+
+	// add new key
+	denom := "stake"
+	subDenom := "test"
+	feeAmount := math.NewInt(1000000)
+
+	sut.ModifyGenesisJSON(
+		t,
+		SetDenomCreationFee(t, denom, feeAmount),
+	)
+
+	// get validator address
+	valAddr := gjson.Get(cli.Keys("keys", "list"), "1.address").String()
+	require.NotEmpty(t, valAddr)
+
+	sut.StartChain(t)
+
+	raw := cli.CustomQuery("q", "bankv2", "balance", valAddr, denom)
+	valBalanceBefore := gjson.Get(raw, "balance.amount").Int()
+
+	rsp := cli.Run("tx", "bankv2", "create-denom", subDenom, "--from", valAddr)
+	txResult, found := cli.AwaitTxCommitted(rsp)
+	fmt.Println("txResult", txResult)
+	require.True(t, found)
+	RequireTxSuccess(t, txResult)
+
+	raw = cli.CustomQuery("q", "bankv2", "balance", valAddr, denom)
+	valBalanceAfter := gjson.Get(raw, "balance.amount").Int()
+
+	require.Equal(t, valBalanceBefore-valBalanceAfter, feeAmount.Int64())
+
+	raw = cli.CustomQuery("q", "bankv2", "denoms-from-creator", valAddr)
+	newDenoms := gjson.Get(raw, "denoms").Array()
+	require.Equal(t, len(newDenoms), 1)
+
+	raw = cli.CustomQuery("q", "bankv2", "denom-authority-metadata", newDenoms[0].String())
+	admin := gjson.Get(raw, "authority_metadata.admin").String()
+	require.Equal(t, admin, valAddr)
+}
+
+func TestMintBurnTokenCmd(t *testing.T) {
+	// Currently only run with app v2
+	if !isV2() {
+		t.Skip()
+	}
+	// given a running chain
+
+	sut.ResetChain(t)
+	cli := NewCLIWrapper(t, sut, verbose)
+
+	// add new key
+	denom := "stake"
+	subDenom := "test"
+	feeAmount := math.NewInt(1_000_000)
+	mintAmount := 1_000_000
+	burnAmount := 500_000
+
+	sut.ModifyGenesisJSON(
+		t,
+		SetDenomCreationFee(t, denom, feeAmount),
+	)
+
+	// get validator address
+	valAddr := gjson.Get(cli.Keys("keys", "list"), "1.address").String()
+	require.NotEmpty(t, valAddr)
+
+	// add new key
+	receiverAddr := cli.AddKey("account1")
+
+	sut.StartChain(t)
+
+	rsp := cli.Run("tx", "bankv2", "create-denom", subDenom, "--from", valAddr)
+	txResult, found := cli.AwaitTxCommitted(rsp)
+	require.True(t, found)
+	RequireTxSuccess(t, txResult)
+
+	raw := cli.CustomQuery("q", "bankv2", "denoms-from-creator", valAddr)
+	newDenoms := gjson.Get(raw, "denoms").Array()
+	require.Equal(t, len(newDenoms), 1)
+
+	// non tokenfactory should not be minted directly
+	rsp = cli.Run("tx", "bankv2", "mint", valAddr, receiverAddr, fmt.Sprintf("%d%s", mintAmount, denom))
+	code := gjson.Get(rsp, "code").Int()
+	require.NotEqual(t, code, int64(0))
+	rawLog := gjson.Get(rsp, "raw_log").String()
+	require.Contains(t, rawLog, "invalid authority")
+
+	rsp = cli.Run("tx", "bankv2", "mint", valAddr, receiverAddr, fmt.Sprintf("%d%s", mintAmount, newDenoms[0]))
+	txResult, found = cli.AwaitTxCommitted(rsp)
+	require.True(t, found)
+	RequireTxSuccess(t, txResult)
+
+	raw = cli.CustomQuery("q", "bankv2", "balance", receiverAddr, newDenoms[0].String())
+	balance := gjson.Get(raw, "balance.amount").Int()
+	require.Equal(t, balance, int64(mintAmount))
+
+	// Burn token from receiver
+	rsp = cli.Run("tx", "bankv2", "burn", valAddr, receiverAddr, fmt.Sprintf("%d%s", burnAmount, newDenoms[0]))
+	txResult, found = cli.AwaitTxCommitted(rsp)
+	require.True(t, found)
+	RequireTxSuccess(t, txResult)
+
+	raw = cli.CustomQuery("q", "bankv2", "balance", receiverAddr, newDenoms[0].String())
+	balance = gjson.Get(raw, "balance.amount").Int()
+	require.Equal(t, balance, int64(mintAmount-burnAmount))
+}
+
+func TestMintBurnTokenProposal(t *testing.T) {
+	// Currently only run with app v2
+	if !isV2() {
+		t.Skip()
+	}
+	// given a running chain
+
+	sut.ResetChain(t)
+	cli := NewCLIWrapper(t, sut, verbose)
+
+	// add new key
+	denom := "stake"
+	subDenom := "test"
+	mintAmount := 1_000_000
+	burnAmount := 500_000
+
+	sut.ModifyGenesisJSON(
+		t,
+		SetGovVotingPeriod(t, time.Second*8),
+		SetGovExpeditedVotingPeriod(t, time.Second*7),
+	)
+
+	// get validator address
+	valAddr := cli.GetKeyAddr("node0")
+	require.NotEmpty(t, valAddr)
+
+	valAddr1 := cli.GetKeyAddr("node1")
+	require.NotEmpty(t, valAddr1)
+
+	// add new key
+	receiverAddr := cli.AddKey("account1")
+
+	sut.StartChain(t)
+
+	// get gov module address
+	resp := cli.CustomQuery("q", "auth", "module-account", "gov")
+	govAddr := gjson.Get(resp, "account.value.address").String()
+
+	rsp := cli.Run("tx", "bankv2", "create-denom", subDenom, "--from", valAddr)
+	txResult, found := cli.AwaitTxCommitted(rsp)
+	require.True(t, found)
+	RequireTxSuccess(t, txResult)
+
+	raw := cli.CustomQuery("q", "bankv2", "denoms-from-creator", valAddr)
+	newDenoms := gjson.Get(raw, "denoms").Array()
+	require.Equal(t, len(newDenoms), 1)
+	fmt.Println("denoms", raw)
+
+	invalidMintProposal := fmt.Sprintf(`
+	{
+ "messages": [
+  {
+   "@type": "/cosmos.bank.v2.MsgMint",
+   "authority": "%s",
+   "to_address": "%s",
+   "amount": {
+     "denom": "%s",
+     "amount": "%d"
+   }
+  }
+ ],
+ "metadata": "ipfs://CID",
+ "deposit": "100000000stake",
+ "title": "mint tokenfactory token",
+ "summary": "testing"
+}`, govAddr, receiverAddr, newDenoms[0], mintAmount)
+
+	invalidMintProposalFile := StoreTempFile(t, []byte(invalidMintProposal))
+	rsp = cli.RunAndWait("tx", "gov", "submit-proposal", invalidMintProposalFile.Name(), "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+
+	// vote to proposal from two validators
+	rsp = cli.RunAndWait("tx", "gov", "vote", "1", "yes", "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+	rsp = cli.RunAndWait("tx", "gov", "vote", "1", "yes", "--from", valAddr1)
+	RequireTxSuccess(t, rsp)
+
+	time.Sleep(8 * time.Second)
+
+	// Token should not be minted to receiver
+	raw = cli.CustomQuery("q", "bankv2", "balance", receiverAddr, newDenoms[0].String())
+	balance := gjson.Get(raw, "balance.amount").Int()
+	require.Equal(t, balance, int64(0))
+
+	validMintProposal := fmt.Sprintf(`
+	{
+ "messages": [
+  {
+   "@type": "/cosmos.bank.v2.MsgMint",
+   "authority": "%s",
+   "to_address": "%s",
+   "amount": {
+     "denom": "%s",
+     "amount": "%d"
+   }
+  }
+ ],
+ "metadata": "ipfs://CID",
+ "deposit": "100000000stake",
+ "title": "mint tokenfactory token",
+ "summary": "testing"
+}`, govAddr, receiverAddr, denom, mintAmount)
+
+	mintProposalFile := StoreTempFile(t, []byte(validMintProposal))
+
+	rsp = cli.RunAndWait("tx", "gov", "submit-proposal", mintProposalFile.Name(), "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+
+	// vote to proposal from two validators
+	rsp = cli.RunAndWait("tx", "gov", "vote", "2", "yes", "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+	rsp = cli.RunAndWait("tx", "gov", "vote", "2", "yes", "--from", valAddr1)
+	RequireTxSuccess(t, rsp)
+
+	time.Sleep(8 * time.Second)
+
+	// stake should be minted to receiver
+	raw = cli.CustomQuery("q", "bankv2", "balance", receiverAddr, denom)
+	balance = gjson.Get(raw, "balance.amount").Int()
+	require.Equal(t, balance, int64(mintAmount))
+
+	validBurnProposal := fmt.Sprintf(`
+	{
+ "messages": [
+  {
+   "@type": "/cosmos.bank.v2.MsgBurn",
+   "authority": "%s",
+   "burn_from_address": "%s",
+   "amount": {
+     "denom": "%s",
+     "amount": "%d"
+   }
+  }
+ ],
+ "metadata": "ipfs://CID",
+ "deposit": "100000000stake",
+ "title": "mint tokenfactory token",
+ "summary": "testing"
+}`, govAddr, receiverAddr, denom, burnAmount)
+
+	burnProposalFile := StoreTempFile(t, []byte(validBurnProposal))
+
+	rsp = cli.RunAndWait("tx", "gov", "submit-proposal", burnProposalFile.Name(), "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+
+	// vote to proposal from two validators
+	rsp = cli.RunAndWait("tx", "gov", "vote", "3", "yes", "--from", valAddr)
+	RequireTxSuccess(t, rsp)
+	rsp = cli.RunAndWait("tx", "gov", "vote", "3", "yes", "--from", valAddr1)
+	RequireTxSuccess(t, rsp)
+
+	time.Sleep(8 * time.Second)
+
+	// stake should be burned from receiver
+	raw = cli.CustomQuery("q", "bankv2", "balance", receiverAddr, denom)
+	balance = gjson.Get(raw, "balance.amount").Int()
+	require.Equal(t, balance, int64(mintAmount-burnAmount))
+}

tests/systemtests/genesis_io.go

@@ -9,7 +9,7 @@ import (
 	"github.com/tidwall/gjson"
 	"github.com/tidwall/sjson"
 
-	sdkmath "cosmossdk.io/math"
+	"cosmossdk.io/math"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
@@ -42,13 +42,22 @@ func SetGovExpeditedVotingPeriod(t *testing.T, period time.Duration) GenesisMuta
 	}
 }
 
+func SetDenomCreationFee(t *testing.T, denom string, amount math.Int) GenesisMutator {
+	t.Helper()
+	return func(genesis []byte) []byte {
+		state, err := sjson.SetBytes(genesis, "app_state.bankv2.params.denom_creation_fee", sdk.NewCoins(sdk.NewCoin(denom, amount)))
+		require.NoError(t, err)
+		return state
+	}
+}
+
 // GetGenesisBalance return the balance amount for an address from the given genesis json
 func GetGenesisBalance(rawGenesis []byte, addr string) sdk.Coins {
 	var r []sdk.Coin
 	balances := gjson.GetBytes(rawGenesis, fmt.Sprintf(`app_state.bank.balances.#[address==%q]#.coins`, addr)).Array()
 	for _, coins := range balances {
 		for _, coin := range coins.Array() {
-			r = append(r, sdk.NewCoin(coin.Get("denom").String(), sdkmath.NewInt(coin.Get("amount").Int())))
+			r = append(r, sdk.NewCoin(coin.Get("denom").String(), math.NewInt(coin.Get("amount").Int())))
 		}
 	}
 	return r