-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(depinject): Add gogo support for depinject #20403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e1e4ea1
gogo types gen
hieuvubk 9828413
abtract ConfigProtoMessage
hieuvubk c6f21a3
Add Compose for gogo app config
hieuvubk 9994a2b
gen gogo test file & add test
hieuvubk a2f4df7
merge main
hieuvubk 148d984
Merge branch 'main' into hieu/depinject_gogo_support
hieuvubk 866da86
helper
hieuvubk 12039fd
as proto.Message
hieuvubk 70cc6c6
wrap compose proto v1 & v2 in 1 func
hieuvubk 4fcd362
go mod tidy & tests
hieuvubk 19c10c8
Merge branch 'main' into hieu/depinject_gogo_support
hieuvubk 36826e9
remove toolchain
hieuvubk 8dc47f6
Merge branch 'hieu/depinject_gogo_support' of https://github.com/cosm…
hieuvubk ddfa652
regen module & config proto
hieuvubk a2e4709
regen testpb gogo test file
hieuvubk d0aac5a
convert gogotypes/any.Any to gogotypes.Any
hieuvubk 22b7c10
refactor
hieuvubk 4d3e17f
Merge branch 'main' into hieu/depinject_gogo_support
hieuvubk fb8ffb8
orm go mod tidy
hieuvubk 6df3128
go mod tidy all
hieuvubk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package appv1alpha1 | ||
|
|
||
| import "fmt" | ||
|
|
||
| func (x *ModuleConfig) GetTypeUrl() (string, error) { | ||
| if x != nil { | ||
| if x.Config != nil { | ||
| return x.Config.TypeUrl, nil | ||
| } else { | ||
| return "", fmt.Errorf("module %q is missing a config object", x.Name) | ||
| } | ||
| } | ||
| return "", fmt.Errorf("Module is nil") | ||
| } | ||
|
|
||
| func (x *ModuleConfig) GetGolangBindingsStrings() ([]string, []string) { | ||
| if x != nil { | ||
| interfaceTypes := make([]string, len(x.GolangBindings)) | ||
| imple := make([]string, len(x.GolangBindings)) | ||
|
|
||
| for i, binding := range x.GolangBindings { | ||
| interfaceTypes[i] = binding.InterfaceType | ||
| imple[i] = binding.Implementation | ||
| } | ||
| return interfaceTypes, imple | ||
| } | ||
| return nil, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom code shouldn't be added to
api. This is all generated code