Skip to content

Conversation

@tac0turtle
Copy link
Contributor

Description

remove home grown version of bootstrap api


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team September 27, 2023 11:36
@ghost ghost requested review from a team, alexanderbez and julienrbrt and removed request for a team September 27, 2023 11:36
Copy link
Contributor

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@julienrbrt julienrbrt changed the title chore: use bootstrap api from comet refactor(server): use bootstrap api from comet Sep 27, 2023
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@tac0turtle tac0turtle added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 1be29b7 Sep 27, 2023
@tac0turtle tac0turtle deleted the marko/update_bootstrap_api branch September 27, 2023 17:27
@julienrbrt
Copy link
Contributor

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2024

backport release/v0.50.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 19, 2024
julienrbrt pushed a commit that referenced this pull request Jan 19, 2024
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants