Skip to content

fix(simapp): do not repeat errors#16865

Merged
tac0turtle merged 2 commits intomainfrom
julien/audit-simapp
Jul 7, 2023
Merged

fix(simapp): do not repeat errors#16865
tac0turtle merged 2 commits intomainfrom
julien/audit-simapp

Conversation

@julienrbrt
Copy link
Contributor

Description

Errors are being repeated in the log and the commands themselves.
This fixes that.

ref: #16864


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team July 6, 2023 23:32
@ghost ghost requested review from a team, alexanderbez and testinginprod and removed request for a team July 6, 2023 23:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@julienrbrt your pull request is missing a changelog!

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bez must have missed it to approve this PR but gave utACK.

@tac0turtle tac0turtle added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit ac6df28 Jul 7, 2023
@tac0turtle tac0turtle deleted the julien/audit-simapp branch July 7, 2023 09:24
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@julienrbrt julienrbrt mentioned this pull request Jul 10, 2023
19 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants