feat: add --initial-height flag to cli init cmd#15147
Merged
julienrbrt merged 5 commits intoFeb 24, 2023
Merged
Conversation
ghost
requested review from
a team,
aaronc and
tac0turtle
and removed request for
a team
fragwuerdig
changed the title
fragwuerdig
force-pushed
the
feat/genutil-add-starting-height
branch
from
6a45baf to
63dd7e8
Compare
fragwuerdig
changed the title
likhita-809
reviewed
Feb 24, 2023
Contributor
likhita-809
left a comment
likhita-809
left a comment
There was a problem hiding this comment.
can you add some tests please ?
| * (x/gov,cli) [#14718](https://github.com/cosmos/cosmos-sdk/pull/14718) Added `AddGovPropFlagsToCmd` and `ReadGovPropFlags` functions. | ||
| * (x/bank) [#14894](https://github.com/cosmos/cosmos-sdk/pull/14894) Return a human readable denomination for IBC vouchers when querying bank balances. Added a `ResolveDenom` parameter to `types.QueryAllBalancesRequest` and `--resolve-denom` flag to `GetBalancesCmd()`. | ||
| * (x/groups) [#14879](https://github.com/cosmos/cosmos-sdk/pull/14879) Add `Query/Groups` query to get all the groups. | ||
| * (x/genutil,cli) [#15147](https://github.com/cosmos/cosmos-sdk/pull/15147) Add `--initial-height` flag to cli init cmd |
Contributor
There was a problem hiding this comment.
can you also specify what initial-height flag does here ?
Author
There was a problem hiding this comment.
Ok... Took care of that. Please, resolve if appropriate.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
@Mergifyio backport release/v0.47.x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
(cherry picked from commit b53be68) # Conflicts: # CHANGELOG.md # x/genutil/client/cli/init.go
julienrbrt
added a commit
that referenced
this pull request
Mar 20, 2023
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15027.
Added flag "--initial-height" to the init command. Tested manually. LMK if that needs to be covered.
The parameter needs to be provided as int, because the genesis doc accepts int. However, this PR defaults negative block heights to 1.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change