refactor: remove class&nft id validation

[dreamer-zq]

Description

Closes: #13819

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

makes sense to me, could we get a changelog entry and update to the spec with this change so applications know they must handle validation

[codecov]

Codecov Report

Merging #13836 (7150dab) into main (ec27c53) will increase coverage by 0.22%.
The diff coverage is 33.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13836      +/-   ##
==========================================
+ Coverage   56.46%   56.68%   +0.22%     
==========================================
  Files         648      642       -6     
  Lines       56221    55136    -1085     
==========================================
- Hits        31747    31256     -491     
+ Misses      21909    21350     -559     
+ Partials     2565     2530      -35     

Impacted Files	Coverage Δ
x/auth/tx/service.go	0.00% <0.00%> (ø)
x/nft/client/cli/query.go	62.43% <ø> (+0.71%)	⬆️
x/nft/keeper/grpc_query.go	70.83% <100.00%> (+1.44%)	⬆️
crypto/keys/internal/ecdsa/privkey.go	81.13% <0.00%> (-1.89%)	⬇️
x/group/keeper/keeper.go	56.25% <0.00%> (-0.40%)	⬇️
simapp/app.go
simapp/upgrades.go
simapp/state.go
simapp/simd/cmd/root.go
simapp/genesis.go
... and 10 more

[julienrbrt]

Can we instead update the validation rule to only check if not empty?
This way this avoids duplicating the error messages, and we are sure we validate the same way everywhere.
+1 for the changelog too.

EDIT: Actually, we could as well just set these errors (errors.Wrap(ErrInvalidID, "empty class id") and errors.Wrap(ErrInvalidID, "empty nft id")) as variable somewhere and use them.

Feedback implemented.

[julienrbrt]

lgtm! Thank you!

Maybe in addition of the ADR changes, we could mention in the specs (https://github.com/cosmos/cosmos-sdk/blob/main/x/nft/README.md) that the app dev is supposed to handle the validation and in the UPGRADING.md.

I can do that in a follow-up too.

[facundomedica]

nit: I think this one can be put back

[facundomedica]

Just tested locally and it can be put back, but we can do a follow-up PR :)

[julienrbrt]

Merging then, I'll update the docs in a quick follow-up and re-add this test.

[facundomedica]

Left a small nit, otherwise, LGTM 🚀