feat: bring back filter logging#13236
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13236 +/- ##
==========================================
- Coverage 55.87% 53.66% -2.22%
==========================================
Files 646 648 +2
Lines 54895 55342 +447
==========================================
- Hits 30675 29701 -974
- Misses 21762 23266 +1504
+ Partials 2458 2375 -83
|
julienrbrt
approved these changes
Sep 12, 2022
Contributor
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
utACK. Do we want to, in a follow up, use the tm logger everywhere that already depends on TM?
Contributor
|
We're reverting #8072, is that right? |
Contributor
Author
Yup yup, i can leave the zero logger if needed |
amaury1093
approved these changes
Sep 12, 2022
Contributor
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
utACK.
That PR has +200LOC, whereas this one only has -100. Did we remove all zerolog instances, or is there a follow-up #13236 (review) ?
Contributor
Author
|
I left cosmovisor untouched, we can migrate in another pr if we want. A lot of the changes were removing fmt.Sprintfs |
julienrbrt
pushed a commit
that referenced
this pull request
Sep 13, 2022
* bring back filter logging * fix build * remove zerologger * add changelog entry & docs * fix lint
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Todos:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change