refactor!: make simapp.MakeTestEncodingConfig private#12747
Merged
Conversation
github-actions
Bot
added
C:CLI
C:Simulations
C:x/bank
C:x/genutil
julienrbrt
changed the title
simapp.MakeTestEncodingConfig privatesimapp.MakeTestEncodingConfig private
kocubinski
approved these changes
Jul 27, 2022
Contributor
kocubinski
left a comment
kocubinski
left a comment
There was a problem hiding this comment.
LGTM, just one question.
| func Test_TestnetCmd(t *testing.T) { | ||
| home := t.TempDir() | ||
| encodingConfig := simapp.MakeTestEncodingConfig() | ||
| encodingConfig := moduletestutil.MakeTestEncodingConfig(staking.AppModuleBasic{}, auth.AppModuleBasic{}) |
Contributor
There was a problem hiding this comment.
What is the logic for only needing staking and auth AppModuleBasic here?
Contributor
Author
There was a problem hiding this comment.
- We marshal the genesis in
initGenFilesso we need auth (https://github.com/cosmos/cosmos-sdk/blob/main/simapp/simd/cmd/testnet.go#L370) - Then here we need
stakingfor the validator msg created there. Otherwise, we getunable to resolve type URL /cosmos.staking.v1beta1.MsgCreateValidator
tac0turtle
approved these changes
Jul 27, 2022
4 tasks
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Thanks for doing this @julienrbrt 🙌
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* feat: make `simapp.MakeTestEncodingConfig` private * fix legacy build * update changelog and upgrading.md * updates docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: #11899. Closes #7642
Makes
simapp.MakeTestEncodingConfigprivate and usemoduletestutil.MakeTestEncodingConfig(...)in tests.TODO
docs/run-node/txs.mdAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change