refactor!: use injected encoding params in simapp#12717
Merged
Conversation
julienrbrt
changed the title
legacyAmino in simapp
julienrbrt
force-pushed
the
julien/use-injected-legacyamino-simapp
branch
from
7226c70 to
dd98b4a
Compare
julienrbrt
changed the title
julienrbrt
commented
Jul 26, 2022
| encodingConfig := simapp.MakeTestEncodingConfig() | ||
| func NewRootCmd() *cobra.Command { | ||
| // we "pre"-instantiate the application for getting the injected/configured encoding configuration | ||
| tempApp := simapp.NewSimApp(log.NewNopLogger(), dbm.NewMemDB(), nil, true, simutil.EmptyAppOptions{}) |
Contributor
Author
There was a problem hiding this comment.
Actually, with the previous behavior we were never certain that the InterfaceRegistry, AppCodec or TxConfig were identical with the encoding config when using app wiring (as these were injected). This fixes it and as well ensures that we use the same params for the legacy app.
julienrbrt
force-pushed
the
julien/use-injected-legacyamino-simapp
branch
from
24697d6 to
2b885cb
Compare
github-actions
Bot
added
C:CLI
C:Cosmovisor
julienrbrt
force-pushed
the
julien/use-injected-legacyamino-simapp
branch
from
75e0862 to
2b885cb
Compare
github-actions
Bot
removed
C:Simulations
C:x/upgrade
C:x/genutil
julienrbrt
force-pushed
the
julien/use-injected-legacyamino-simapp
branch
from
2b885cb to
46613ad
Compare
tac0turtle
reviewed
Jul 27, 2022
tac0turtle
approved these changes
Jul 27, 2022
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
utACK. the clean makes seperation better
Codecov Report
@@ Coverage Diff @@
## main #12717 +/- ##
=======================================
Coverage ? 56.36%
=======================================
Files ? 648
Lines ? 55340
Branches ? 0
=======================================
Hits ? 31190
Misses ? 21631
Partials ? 2519
|
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* refactor!: use injected encoding params in simapp * add upgrading.md entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Investigating the possibility of using injected encoding params in
NewSimAppand simplifyNewSimAppconstructor arguments.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change