fix: add cosmos_proto implements#12639
Merged
mergify[bot] merged 3 commits intocosmos:mainfrom Jul 20, 2022
pyramation:cosmos-proto-implements-interface
Merged
fix: add cosmos_proto implements#12639mergify[bot] merged 3 commits intocosmos:mainfrom pyramation:cosmos-proto-implements-interface
mergify[bot] merged 3 commits intocosmos:mainfrom
pyramation:cosmos-proto-implements-interface
Conversation
4 tasks
alexanderbez
approved these changes
Jul 20, 2022
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
ACK. Note, these are legacy proposals and most likely will not be used going forward.
amaury1093
approved these changes
Jul 20, 2022
Contributor
|
@AmauryM does this need to be back ported to 0.46? |
Contributor
|
Maybe that's a question for @pyramation ? It's totally fine to backport it if you need it in v0.45 or v0.46 |
Contributor
Author
we should definitely have this in 0.46 if we want codgen tooling, so I believe so! |
Contributor
|
@Mergifyio backport release/0.46.x |
Contributor
❌ No backport have been createdDetails
|
Contributor
|
https://github.com/Mergifyio backport release/v0.46.x |
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`: ``` option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content" ``` Would this be a breaking change? Happy to improve/amend this so it's mergeable. related issue: #12640 (cherry picked from commit 64674ba)
Contributor
✅ Backports have been createdDetails
|
amaury1093
pushed a commit
that referenced
this pull request
Jul 21, 2022
It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`: ``` option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content" ``` Would this be a breaking change? Happy to improve/amend this so it's mergeable. related issue: #12640 (cherry picked from commit 64674ba) Co-authored-by: Dan Lynch <pyramation@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we're missing the
cosmos_proto.implements_interfaceon many proposal messages/structsthis is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement
Content:Would this be a breaking change? Happy to improve/amend this so it's mergeable.
related issue: #12640