Repository navigation
V5.8.6: leap seconds are valid date-times on the days that ended with one, and time offsets take any hour RFC 3339 allows - #1062
Merged
Merged
Conversation
…d time offsets take any hour RFC 3339 allows date-time accepts a second of 60 only at 23:59:60 UTC on the 27 days the IERS ended with a leap second (1972-06-30 to 2016-12-31), in any offset. time accepts it at 23:59:60 UTC. Both accept offset hours 00 to 23, which RFC 3339 allows; the checks refused offsets over 14 hours. FormatMatchers reads full-time itself, so the typed parsers, which convert to DateTimeOffset and NodaTime, are unchanged. V4 compiles the same source. The leap-second exclusions are removed from the V5 and V4 suite generators and the runtime evaluator's suite tests, and the suite tests are regenerated (V4: the new test methods only, without the template's boilerplate drift). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
…iable The organisation variable ZF_BUILD_DOTNET_NUGET_TRUSTED_PUBLISHING_USER (endjin-nuget) replaces the repository variable NUGET_TRUSTED_PUBLISHING_USER. build.yml keeps Trusted Publishing to nuget.org destinations: the organisation's ZF_BUILD_DOTNET_NUGET_USE_TRUSTED_PUBLISHING is true for every build, but branch builds publish to GitHub Packages with a key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
Contributor
Code Coverage Summary Report - Linux (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.6%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 80.1%
Corvus.Json.JsonReference - 76.4%
Corvus.Text.Json - 91.9%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Contributor
Code Coverage Summary Report - Windows (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.6%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 80.1%
Corvus.Json.JsonReference - 76.6%
Corvus.Text.Json - 91.8%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Code Coverage Summary Report - Windows (net481)Summary
CoverageCorvus.Json.CodeGeneration - 78.9%
Corvus.Json.CodeGeneration.CSharp - 83.2%
Corvus.Json.ExtendedTypes - 78.2%
Corvus.Json.JsonReference - 73.6%
Corvus.Text.Json - 91%
Corvus.Text.Json.CodeGeneration - 64.3%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.8%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.6%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 95%
Corvus.Text.Json.JsonPath.CodeGeneration - 96.1%
Corvus.Text.Json.Patch - 96.6%
Corvus.Text.Json.Toon - 88.2%
Corvus.Text.Json.Validator - 93.7%
Corvus.Text.Json.Yaml - 90.8%
Corvus.Toon.SystemTextJson - 90%
|
Contributor
|
The documentation preview for this pull request has been removed. |
This was referenced Nov 8, 2026
Merged
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V5.8.6: the
date-timeandtimeformats accept leap seconds, and accept every time offset RFC 3339 allows. V4 compiles the same format checks, so it changes in the same way.What changes
date-timeaccepts a second of60only at 23:59:60 UTC on the 27 days the IERS ended with a leap second, 1972-06-30 to 2016-12-31, in whatever offset the value is written.1998-12-31T15:59:60-08:00is valid, and2017-12-31T23:59:60Zand1998-12-31T23:58:60Zare not.timehas no date, so it accepts a second of60whenever the time is 23:59 UTC (23:59:60Z,15:59:60-08:00).FormatMatchersnow reads RFC 3339full-timeitself. The typed date and time parsers, which convert toDateTimeOffsetand NodaTime types, are unchanged, so a parsed value still refuses what those types can't hold.The
timerule is the one for drafts 4 to 2020-12. The V1 dialect rejects leap seconds intime, and that comes with the V1 work.Tests
JsonSchemaMatchingStringTests. The 15 that expect a valid value fail on the old matcher and pass on the new one.The ports follow in their own PRs, and the leap exclusions in #1058 come out as each one ships.
Publishing
This is the first release through the shared pipeline's Publish job with Trusted Publishing (#1060). A second commit takes the nuget.org user from the organisation variable
ZF_BUILD_DOTNET_NUGET_TRUSTED_PUBLISHING_USER(endjin-nuget, which has a publishing policy for this repository) in place of the repository variableNUGET_TRUSTED_PUBLISHING_USER, so this release tests the setup we keep.build.ymlstill turns Trusted Publishing on only for a nuget.org destination, because the organisation'sZF_BUILD_DOTNET_NUGET_USE_TRUSTED_PUBLISHINGis true for every build and branch builds publish to GitHub Packages with a key.docs/ReleaseProcess.mdsays so. I'll watch the tag build's Publish job and check the packages reach nuget.org. Once they have, the repository variable can be deleted.🤖 Generated with Claude Code
https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3