Repository navigation
Notices: the UTS #46 table is Unicode data, so every package that holds it carries its notice - #1056
Merged
Merged
Conversation
…ds it carries its notice The format checks of #1053 compile a table derived from IdnaMappingTable.txt (Unicode 17.0.0) into every engine, and no notice named it. Each THIRD-PARTY-NOTICES.txt gains a paragraph for it in its Unicode section. The Rust crate (which has had no notices file since its pattern tables moved to corvus-regex-ecma262) and the TypeScript package get one, packaged with them, and Corvus.Json.ExtendedTypes, which links the table, packs the .NET notices file. The Alien::CorvusJsonSchema notice takes the C library's current text, since it installs C library 0.1.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
…rated projects The solution referenced seven BenchmarkDotNet.Autogenerated.csproj files under bin/Release, which never exist in a clean checkout. Nothing uses the solution (the project builds on its own and from the repository solutions), but GitHub's automatic NuGet dependency submission restores whichever project files it finds first, and fails whenever this one is among them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
Contributor
|
The documentation preview for this pull request has been removed. |
Contributor
Code Coverage Summary Report - Linux (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.4%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 81.1%
Corvus.Json.JsonReference - 76.4%
Corvus.Text.Json - 91.9%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Test Results 48 files 48 suites 9m 11s ⏱️ Results for commit 25e481b. ♻️ This comment has been updated with latest results. |
Contributor
Code Coverage Summary Report - Windows (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.5%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 81.1%
Corvus.Json.JsonReference - 76.6%
Corvus.Text.Json - 91.8%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Code Coverage Summary Report - Windows (net481)Summary
CoverageCorvus.Json.CodeGeneration - 78.7%
Corvus.Json.CodeGeneration.CSharp - 83.2%
Corvus.Json.ExtendedTypes - 79.3%
Corvus.Json.JsonReference - 73.6%
Corvus.Text.Json - 91%
Corvus.Text.Json.CodeGeneration - 64.3%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.8%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.6%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 95%
Corvus.Text.Json.JsonPath.CodeGeneration - 96.1%
Corvus.Text.Json.Patch - 96.6%
Corvus.Text.Json.Toon - 88.2%
Corvus.Text.Json.Validator - 93.7%
Corvus.Text.Json.Yaml - 90.8%
Corvus.Toon.SystemTextJson - 90%
|
This was referenced Nov 8, 2026
Merged
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1053 compiled a table derived from Unicode's
IdnaMappingTable.txt(the UTS #46 IDNA mapping data, Unicode 17.0.0) into every engine, for theidn-hostnamemapping. That data is under the Unicode License V3, whose notice must go with copies, and no notice named the table. This adds it. Documentation only: no code changes, so it is labelledno_releaseand each package carries the notice from its next release.What changes
THIRD-PARTY-NOTICES.txtthat covers a package holding the table gains a paragraph naming its table (uts46_data.go,Uts46Data.java,src/uts46_data.rsof the crate, and so on) in its Unicode section, ahead of the licence text it already carries: .NET (the shared file), Go, Java, Julia, OCaml, Pascal, pure Perl, pure Python, and the crate's bindings (C library, PHP, Ruby, Rust-backed Python). R's notice already has it (R package 0.1.3 on crate 0.2.1, and Alien::CorvusJsonSchema v0.1.1 on C library 0.1.6 #1055).includeand the package'sfileslist it, andcargo package --listandnpm pack --dry-runshow it. Their READMEs say so.Corvus.Json.ExtendedTypespacks the .NET notices file: it links the format checks, table included, and did not carry it (the.nupkgnow holds it).The packages already published are unchanged: the notice ships with each package's next release.
Second commit: a stray solution file
GitHub's automatic NuGet dependency submission restores the first project files
findreturns, and on this branch they includedsrc-v4/Corvus.Json.Benchmarking/Corvus.Json.Benchmarking.sln. That solution lists sevenBenchmarkDotNet.Autogenerated.csprojfiles underbin/Release, which never exist in a clean checkout, so thesubmit-nugetcheck failed (twice: the order is the same for a given commit). Nothing references the solution; the project builds on its own and from the repository solutions. The commit deletes it.🤖 Generated with Claude Code
https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3