Repository navigation
Publish to NuGet.org with Trusted Publishing, and release V5.8.4 (which ships V5.8.1 to V5.8.3) - #1054
Merged
Conversation
A Publish job of build.yml, with id-token: write, runs the ZeroFailed Publish task on the packages the build's package phase cached, and ZeroFailed.Build.DotNet exchanges the GitHub Actions OIDC token for a NuGet.org key valid for an hour. The shared pipeline's Publish job cannot have id-token: write without stopping every other caller, so it runs an empty task. The long-lived NUGET_APIKEY secret is no longer used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
…never published to NuGet.org Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3
Contributor
Code Coverage Summary Report - Windows (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.5%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 81.1%
Corvus.Json.JsonReference - 76.6%
Corvus.Text.Json - 91.8%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Code Coverage Summary Report - Linux (net10.0)Summary
CoverageCorvus.Json.CodeGeneration - 80.4%
Corvus.Json.CodeGeneration.CSharp - 83.5%
Corvus.Json.ExtendedTypes - 81.1%
Corvus.Json.JsonReference - 76.4%
Corvus.Text.Json - 91.9%
Corvus.Text.Json.AsyncApi - 71%
Corvus.Text.Json.AsyncApi.Amqp - 0.2%
Corvus.Text.Json.AsyncApi.AzureServiceBus - 0%
Corvus.Text.Json.AsyncApi.CodeGeneration - 93.5%
Corvus.Text.Json.AsyncApi.Kafka - 0.2%
Corvus.Text.Json.AsyncApi.Mqtt - 0.4%
Corvus.Text.Json.AsyncApi.Nats - 0.2%
Corvus.Text.Json.AsyncApi.Polly - 57.8%
Corvus.Text.Json.AsyncApi.Testing - 96.2%
Corvus.Text.Json.AsyncApi.WebSocket - 0.6%
Corvus.Text.Json.CodeGeneration - 89.8%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.6%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.5%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 94.7%
|
Contributor
Contributor
Code Coverage Summary Report - Windows (net481)Summary
CoverageCorvus.Json.CodeGeneration - 78.7%
Corvus.Json.CodeGeneration.CSharp - 83.2%
Corvus.Json.ExtendedTypes - 79.3%
Corvus.Json.JsonReference - 73.6%
Corvus.Text.Json - 91%
Corvus.Text.Json.CodeGeneration - 64.3%
Corvus.Text.Json.JMESPath - 93.8%
Corvus.Text.Json.JMESPath.CodeGeneration - 97.7%
Corvus.Text.Json.Jsonata - 91.8%
Corvus.Text.Json.Jsonata.CodeGeneration - 88.6%
Corvus.Text.Json.JsonLogic - 95.1%
Corvus.Text.Json.JsonLogic.CodeGeneration - 92.8%
Corvus.Text.Json.JsonPath - 95%
Corvus.Text.Json.JsonPath.CodeGeneration - 96.1%
Corvus.Text.Json.Patch - 96.6%
Corvus.Text.Json.Toon - 88.2%
Corvus.Text.Json.Validator - 93.7%
Corvus.Text.Json.Yaml - 90.8%
Corvus.Toon.SystemTextJson - 90%
|
Contributor
|
The documentation preview for this pull request has been removed. |
This was referenced Nov 8, 2026
Merged
Bump Corvus.Json.Validator and meziantou.framework.nugetpackagevalidation.tool
Joseleno/Incognito#75
Merged
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NuGet.org refused the packages of V5.8.1, V5.8.2 and V5.8.3: the long-lived API key the release build used had expired. This PR moves NuGet.org publishing to Trusted Publishing, so no key is stored and none can expire. Its merge releases V5.8.4, the first NuGet.org release since V5.8.0, which ships everything in the three.
How it publishes
Publishjob ofbuild.yml, withid-token: write. On tag runs (and manual force-publish runs) it restores the packages the build's package phase cached and runs the ZeroFailedPublishtask. ZeroFailed.Build.DotNet (since feat: support publishing to NuGet.org via Trusted Publishing (OIDC) zerofailed/ZeroFailed.Build.DotNet#38) exchanges the GitHub Actions OIDC token for a NuGet.org key valid for an hour.Publishjob runs an empty task (RunFirst). endjin's reusable workflow cannot give its publish jobid-token: writewithout stopping every caller that does not grant it (38 of 40 public callers), so that change is not made there.PrePublishcheck still fails a publish that finds no packages (the 5.7.6 guard).BUILD_PUBLISHER_PAT. TheNUGET_APIKEYsecret is no longer read.Set up
corvus-dotnet, repositorycorvus-dotnet/Corvus.JsonSchema, workflow filebuild.yml, no environment.NUGET_TRUSTED_PUBLISHING_USER=mwadams.Both are in place. docs/ReleaseProcess.md describes them.
Release notes
VERSIONHISTORY.mdgains V5.8.4, which states that V5.8.1 to V5.8.3 were tagged and have GitHub releases but were never published to NuGet.org, and summarises what each ships. Their headings say "not published to NuGet.org; shipped in V5.8.4", and their GitHub releases carry the same note.Verification
build.yml, the workflow thePublishjob is in), the job fails before pushing anything, and the fix is to the policy.🤖 Generated with Claude Code
https://claude.ai/code/session_011rjLiHWYWRFfJb3dkSsnE3