Conversation
Jonasdoubleyou
left a comment
There was a problem hiding this comment.
I am wondering a bit of this "middle ground" here of storing it as "just some JSON" but then typing it with enums. Do we plan to build backend logic on top of it? If yes, I would prefer to type it more explicitly also in the DB to ensure a consistent DB state to build the logic on. If no, then IMO we don't even need the enums and can just store some free text information or a generic experience: { name: string, duration: number }[] that the screener frontend can fill as they want ...
prisma/migrations/20260223081308_add_student_experience/migration.sql
Outdated
Show resolved
Hide resolved
Do we need to track this over time? So "when the screening was done, the student was ..." |
|
I could think of the following usecases: (1) Statistics on top of the experience and (2) matching with experience as constraint? Then maybe rather make it explicit in the DB: Also as a sidenote, while I am all for sensitive language in the UI / our user communication, it sometimes is really generic - i.e. "experience" really could be anything. Not sure if a more explicit term would be better internally? |
|
Thank you for the feedback @Jonasdoubleyou! formalEducation String?
// adhs, dyslexia, etc...
specialTeachingExperience String[] @default([])wdyt? |
Ticket
Backend part of https://github.com/corona-school/project-user/issues/1588
What was done?
studentUpdatemutation to include new fieldsNote
I decided to include the
jobStatusfield on the student table as it make more sense there than in the screening tables.I'll make in a moment a separate PR to "deprecate" those fields on the screenings tables.
I'll also write a migration for that so we can deprecate the other fields on the screening tables