fix(tools): Prevent infinite update loop in SplineROITool #2453
+39
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When adding or editing a contour segmentation using any of the SplineROI based tools (e.g., CatmullRomSplineROI, LinearSplineROI, BSplineROI), an infinite loop of SEGMENTATION_DATA_MODIFIED events was triggered.
This issue was caused within the renderAnnotationInstance method of the SplineROITool. During every render pass, the tool would recalculate the spline's polyline and call updateContourPolyline. This process unconditionally marked the annotation as invalidated, which in turn triggered a new SEGMENTATION_DATA_MODIFIED event and a subsequent re-render, leading to a feedback loop.
Changes & Results
Modified
SplineROITool.ts:Effect of the change:
Testing
This fix was tested locally by monitoring the SEGMENTATION_DATA_MODIFIED event to ensure it no longer fires in a loop.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment