-
Notifications
You must be signed in to change notification settings - Fork 444
feat: Improve examples default style #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Improve examples default style #2383
Conversation
|
@sedghi let me know if this makes sense. I updated things so all new examples inherit the styles. |
|
If there is a light mode too i'm fine and a toggle to switch - not all like or can use dark mode |
|
@sedghi sure, added. Check screenshot. |
|
|
I think some screenshots need updating. Let's check if the CI passes. |
|
@wayfarer3130 what do you think? worth merging? |
|
can you do a fake commit so that ci runs |
…at/layout-to-examples
|
@sedghi it ran again but playright tests got cancelled again |
|
can you run them locally? |
…at/layout-to-examples
Context
The examples pages were ugly. Now it's better.
Changes & Results
Changes Made:
Increased max-width for all examples (1400px → 1600px):
example-styles.cssFixed toggle button colors in
addToggleButtonToToolbar.ts:#5acce6) with dark text#090B2B) with white textUpdated HTML examples in
examplesOld/directory:wadouri/index.html,wadors/index.html,dicomfile/index.html,wadourimultiframe/index.html,progressive-jph/index.html,index.htmlFixed DICOM Image Loader example:
layout.tsto add dark background and border to cornerstone elementResolved text overflow issues in PET-CT example:
Results:
Testing
#090B2B) instead of whiteChecklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment