Adding stoptimeout and stopparentfirst for clean shutdown support #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow the service to exit cleanly, we need to only exit when the child does.
This is where we could add a timeout. Poll until we reach the timeout, then force kill.
stoptimeout is now exposed as a parameter
Adding a countdown before sending a SIGKILL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followon from the node-windows pull request.
I have not really tested the debian systemv path yet. I will probably get to that on Monday. But it is a really small change using the existing daemon script so I thought I would get this started.
The stopparentfirst argument doesn't seem applicable to the systemv path, as that is the default behavior.