Skip to content

Conversation

@trapperhoney
Copy link

The signatures for these function recently change to include an optional
options structure in
godbus/dbus@0c07171

Update references appropriately.

The signatures for these function recently change to include an optional
options structure in
godbus/dbus@0c07171

Update references appropriately.
@lucab
Copy link
Contributor

lucab commented Oct 26, 2018

@trapperhoney see #293 (comment).

@trapperhoney
Copy link
Author

Thanks, I guess that explains why the build checks failed... However, this breaks all of the packages that depend on this one (which is how I ended up here) since the dbus code is not included in a vendor directory of this project... Maybe I'm missing some feature of 'go get' that is capable of parsing .toml files?

@lucab
Copy link
Contributor

lucab commented Oct 26, 2018

@trapperhoney you are not missing that. However, you should instead pin and vendor dependencies in whatever application is consuming this. There are a few dependency managers to do that so you can pick the one you prefer. The TOML manifest here is in the dep format.

@lucab
Copy link
Contributor

lucab commented Oct 30, 2018

duplicate of #296

go-dbus 5.0 got released, and the above PR fixed this same issue. Closing.

@lucab lucab closed this Oct 30, 2018
@purpleidea
Copy link
Contributor

@trapperhoney , sorry to re-write this patch. I didn't realize there was a dupe until I had sent mine. All merged now anyways. Woo!

@trapperhoney
Copy link
Author

Thank you both! Mine wasn't the first patch either ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants