fix comparison precedence order in the IsNotExist() method#72
Merged
lucab merged 1 commit intocoreos:masterfrom Dec 16, 2019
Merged
fix comparison precedence order in the IsNotExist() method#72lucab merged 1 commit intocoreos:masterfrom
lucab merged 1 commit intocoreos:masterfrom
Conversation
aojea
changed the title
lucab
reviewed
Dec 16, 2019
The comparison done in the IsNotExist method is missing the parenthesis aggregating the logical or statements, thus the expression evaluation is not working as expected. Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
aojea
force-pushed
the
fix_isnotexist_bug
branch
from
d9f0898 to
2a66665
Compare
lucab
approved these changes
Dec 16, 2019
Contributor
Author
|
who can merge this PR and do a new release so I can update containernetworking/plugins#421 ? |
Contributor
|
@aojea thanks for the followup. Tagged as https://github.com/coreos/go-iptables/releases/tag/v0.4.5. |
Contributor
Author
|
sweet, @lucab thank you very much Just updated containernetworking/plugins#421 with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison done in the IsNotExist method is missing
the parenthesis aggregating the logical or statements,
thus the expression evaluation is not working as
expected.
Signed-off-by: Antonio Ojea antonio.ojea.garcia@gmail.com