Skip to content

iptables IsNotExist robustness#71

Merged
squeed merged 1 commit intocoreos:masterfrom
aojea:wait
Dec 13, 2019
Merged

iptables IsNotExist robustness#71
squeed merged 1 commit intocoreos:masterfrom
aojea:wait

Conversation

@aojea
Copy link
Contributor

@aojea aojea commented Dec 12, 2019

iptables appends sometimes more logs to the error message.
The function err.IsNotExist fails when it does't match the exact string.
We make the function more robust matching for the substring inside the error message.

xref: containernetworking/plugins#421 (comment)

iptables appends sometimes more logs to the error message.
The function err.IsNotExist fails when it does't match the
exact string.
We make the function more robust matching for the substring
inside the error message.

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@aojea
Copy link
Contributor Author

aojea commented Dec 12, 2019

@squeed please take a look

containernetworking/plugins#421 (comment)

@squeed
Copy link
Contributor

squeed commented Dec 13, 2019

makes sense.

@squeed squeed merged commit c0ec0e7 into coreos:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants