Add support for iptables in nftables mode.#51
Merged
squeed merged 1 commit intocoreos:masterfrom Aug 3, 2018
Merged
Conversation
Contributor
Author
|
@lucab would you mind taking a look? |
lucab
reviewed
Aug 3, 2018
Contributor
lucab
left a comment
lucab
left a comment
There was a problem hiding this comment.
Couple of minor nits, otherwise LGTM.
test
Outdated
| sudo -E bash -c "PATH=\$GOROOT/bin:\$PATH go test ${COVER} $@ ${TEST}" | ||
| sudo -E bash -c "${bin} $@ ${TEST}" | ||
| echo "Success" | ||
| rm ${bin} |
Contributor
There was a problem hiding this comment.
Here and above, please quote variables in "": "${bin}" etc.
iptables/iptables.go
Outdated
| if groups := counterRegex.FindStringSubmatch(rule); groups != nil { | ||
| // drop the brackets | ||
| rule = rule[len(groups[0]):] | ||
| rule = fmt.Sprintf("%s -c %s %s", rule, groups[1], groups[2]) |
Contributor
There was a problem hiding this comment.
Nit: I'd personally prefer not shadowing input parameters and local variables, if possible.
Iptables also has the ability to work in nftables mode, where it is supposed to act like iptables but use the nftables subsystem. Unfortunately, it isn't exactly the same. The biggest difference is that counter output is iptables-save style, rather than with "-c N N". Also, improve some tests.
Contributor
Author
|
Updated, and added another fix for a failing testcase; PTAL |
lucab
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iptables also has the ability to work in nftables mode, where it is supposed to act like iptables but use the nftables subsystem. Unfortunately, it isn't exactly the same.
The biggest difference is that counter output is iptables-save style, rather than with "-c N N".
Also, improve some tests.
Fixes: #49