Add a flag for iptables supporting --random-fully#48
Conversation
This is important for Flannel on Kubernetes.
ghost
mentioned this pull request
squeed
suggested changes
Jun 15, 2018
Contributor
squeed
left a comment
squeed
left a comment
There was a problem hiding this comment.
I think we need a public function to expose this too.
The other hasFoo properties are only used internally so the library can select the optimal locking strategy; they're not exposed to the user.
So, can you also add a getter function HasRandomFully()? That way users of the library can construct the best SNAT line.
While you're in there, can you add a getter for the iptables version? We might as well expose it directly.
Author
|
@squeed Added the getter, and also started storing the extracted iptables version and added a getter for that as well. |
squeed
approved these changes
Jul 4, 2018
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important for Flannel on Kubernetes, see https://tech.xing.com/a-reason-for-unexplained-connection-timeouts-on-kubernetes-docker-abd041cf7e02 and kubernetes/kubernetes#56903 for some background information.