qemuvariants: use correct Azure VMDK format #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

darkmuggle wants to merge 1 commit into coreos:master from darkmuggle:pr/azure-vmdk

Contributor

darkmuggle commented Feb 3, 2020

coreos/fedora-coreos-tracker#361

Azure VMDK's require a fixed size. This change uses the qemu-img convert
required to produce a compliant disk.

openshift-ci-robot commented Feb 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkmuggle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [darkmuggle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

arithx commented Feb 3, 2020

Do we need to add something to ensure that it's also a multiple of 1024 bytes?

jomeier commented Feb 3, 2020

yes:

echo "Convert vhd file to raw image..."
qemu-img convert -f vpc -O raw fcos.vhd fcos.raw

# Calculcate new size which is a multiple of 1MByte (rounded up).
rawdisk="fcos.raw"
vhddisk="fcos.vhd"
MB=$((1024*1024))
size=$(qemu-img info -f raw --output json "$rawdisk" | gawk 'match($0, /"virtual-size": ([0-9]+),/, val) {print val[1]}')
rounded_size=$((($size/$MB + 1) * $MB))

echo "Resize raw image..."
qemu-img resize fcos.raw $rounded_size
qemu-img convert -f raw -o subformat=fixed,force_size -O vpc fcos.raw fcos-fixed.vhd

Member

jlebon commented Feb 3, 2020

Can we do #1097 first? This will avoid having to copy the whole 8G across mount boundaries.

Contributor Author

darkmuggle commented Feb 3, 2020

Can we do #1097 first? This will avoid having to copy the whole 8G across mount boundaries.

I don't think that #1097 is required, but I see no reason not to.

darkmuggle added hold WIP labels


          qemuvariants: use correct Azure VMDK format

57ebf88

coreos/fedora-coreos-tracker#361

Azure VMDK's require a fixed size. This change uses the qemu-img convert
required to produce a compliant disk.

lucab pushed a commit to lucab/coreos-assembler that referenced this pull request


          mantle: bump to 02d2d5d

280a05a

Add ore command to list enabled AWS regions.

$ git shortlog b1c2b85..02d2d5d
Benjamin Gilbert (5):
      *: drop legacy names for Packet plans
      Merge pull request coreos#1095 from bgilbert/plan
      vendor: bump aws-sdk-go to 1.25.14
      cmd/ore: add command to list enabled AWS regions
      Merge pull request coreos#1099 from bgilbert/region

miabbott reviewed

View reviewed changes

src/cosalib/azure.py

Comment on lines +27 to +31

    
                     'qemu-img', 'convert',

                     '-f', qemu_info.get("format", "raw"),

                     '-O', 'vpc',

                     '-o', 'subformat=fixed',

                     image, new_img

Member

miabbott Feb 4, 2020

Indentation is off here; causing flake8 to complain

Contributor Author

darkmuggle commented Feb 4, 2020

Withdrawling the request. The qemu-img that comes with F31 does not produce stable VPC/VHDs when the size is fixed. In testing I'm seeing most of the images come out as raw. We can create vpc images, but adding -o subformat=fixed,force_size does not work reliably.

darkmuggle closed this

Contributor Author

darkmuggle commented Feb 4, 2020

For transparency: I've asked @arithx to take a look at using Ore to do the transform. Once we get that, I can plumb this into COSA trivially.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

16 similar comments

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 4, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

16 similar comments

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jlebon added the needs-rebase label

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment

openshift-ci-robot commented Feb 5, 2020

@darkmuggle: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

darkmuggle deleted the pr/azure-vmdk branch

February 18, 2020 21:48

jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request


          Merge pull request coreos#1095 from bgilbert/plan

3b3e709

*: drop legacy names for Packet plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold needs-rebase WIP