aliyun: fix passing '' to ore aliyun copy-image
#1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no config is given, we don't want to pass the empty string as a separate argument. Split out that logic so we only append the arg if it's provided.
miabbott
approved these changes
Jan 28, 2020
Member
miabbott
left a comment
miabbott
left a comment
There was a problem hiding this comment.
Looks sane to me. Should fix a problem we are seeing in the RHCOS pipeline.
lucab
pushed a commit
to lucab/coreos-assembler
that referenced
this pull request
Feb 4, 2020
```
Colin Walters (3):
network: Honor MANTLE_SSH_DIR
kola: Note qemu-unpriv now has networking
kola: Drop torcx tests
Jakub Čajka (1):
kola: initial ppc64le support
Stephen Lowrie (15):
vendor: add aliyun related dependencies
network/*ssh: Add HostKeyCallback to ClientConfig
auth: add aliyun auth provider
platform/api/aliyun: add the aliyun platform
cmd/ore/aliyun: add image creation related aliyun calls
docs: add Aliyun platform documentation
Merge pull request coreos#1066 from arithx/aliyun
Merge pull request coreos#1081 from cgwalters/ssh-agent-tmpdir
Merge pull request coreos#1086 from cgwalters/platform-qemu-unpriv-net
README: update qemu-unpriv notes
Merge pull request coreos#1087 from cgwalters/kola-prune-cl
kola/tests: disable additional clustered tests on qemu-unpriv
Merge pull request coreos#1090 from arithx/disable_tests_on_unpriv
Merge pull request coreos#1088 from arithx/unpriv_readme
Merge pull request coreos#1067 from jcajka/ppc64le
Stephen Milner (1):
Merge pull request coreos#1070 from ashcrow/kola-crio-restart-test
Steve Milner (1):
kola/tests/crio/crio: Add pods and service restart test
```
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
network: Honor MANTLE_SSH_DIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no config is given, we don't want to pass the empty string as a
separate argument. Split out that logic so we only append the arg if
it's provided.