ibmcloud/classic: source network configuration from metadata#316
Merged
lucab merged 1 commit intocoreos:masterfrom Nov 29, 2019
Merged
Conversation
This adds initial support for parsing network metadata available on the config-drive on `ibmcloud` Classic instances.
lucab
force-pushed
the
ups/ibmcloud-classic-network-metadata
branch
from
ff1edc6 to
011f395
Compare
Contributor
Author
|
@jlebon if you have some slots for a review, PTAL. |
jlebon
approved these changes
Nov 28, 2019
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Not familiar with IBM Cloud, but code looks reasonable to me!
Contributor
Author
|
Cross-referencing: achanda/ipnetwork#103. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial support for parsing network metadata available
on the config-drive on
ibmcloudClassic instances.