travis: test with stable and beta, but not nightly #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's probably a good thing if the spaceapi builds with the latest stable toolchain, not only with beta and nightly.
Member
|
Do you know, why the build is failing? |
Member
Author
|
Have you looked at it? It fails to download the toolchain and timeouts after 10 minutes. |
Member
There was a problem hiding this comment.
Does this only allow dead code for tests, or for every build?
Member
|
I totally agree about building on stable and beta :) Back when we introduced testing, stable was not yet available. |
dbrgn
added a commit
that referenced
this pull request
Jul 22, 2015
travis: test with stable and beta, but not nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably a good thing if the spaceapi builds with the latest stable
toolchain, not only with beta / nightly.
Also I removed nightly because recently we hit a compiler bug: https://travis-ci.org/coredump-ch/spaceapi/builds/69862138, see rust-lang/rust#26807 which fixed the error.
But maybe that's a good thing, so we uncover bugs in rustc.