Add fixtures for test_kickstart test coverage#945
Draft
Mearman wants to merge 10 commits intocoredevices:mainfrom
Draft
Add fixtures for test_kickstart test coverage#945Mearman wants to merge 10 commits intocoredevices:mainfrom
Mearman wants to merge 10 commits intocoredevices:mainfrom
Conversation
Mearman
force-pushed
the
fix/test-kickstart
branch
3 times, most recently
from
ead29ca to
998bd78
Compare
Member
|
commits follow |
Require commit messages to use path-based areas (e.g., fw/drivers/hrm) or known short areas (e.g., ci, docs, treewide) rather than conventional commit types like feat:, fix:, chore:. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Append -darwin suffix to fixture filenames on macOS to handle rendering differences in font libraries. Linux (CI) uses standard ~platform naming to match existing fixtures. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Use memcpy for BD_ADDR_t address fields instead of direct assignment, which was causing incorrect address comparisons in whitelist operations. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Add run-tests-docker.sh to run tests in Docker matching CI environment, and generate-linux-fixtures.sh to generate Linux-specific test fixtures. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Mearman
force-pushed
the
fix/test-kickstart
branch
2 times, most recently
from
9e8e49f to
a6a6101
Compare
Document the cross-platform fixture naming scheme, Docker testing workflow, and troubleshooting for CI vs local test discrepancies. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Mearman
force-pushed
the
fix/test-kickstart
branch
from
a6a6101 to
f712aa2
Compare
Restore platform suffix on Linux (e.g. ~spalding) while keeping the additional -darwin suffix for macOS local development. This matches the naming convention of the PNG fixture files in the repository. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Add expected output fixtures for test_kickstart tests covering various display states including heart rate, steps, and obstructed areas. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Remove test_kickstart.c from BROKEN_TESTS now that fixtures are available. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
Mearman
force-pushed
the
fix/test-kickstart
branch
from
d9b8463 to
3fecf75
Compare
Create symlinks with ~spalding suffix for Linux CI compatibility. Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
The kickstart tests were failing on Linux CI because the fixtures were generated on macOS which renders differently. Updated the spalding platform fixtures with Linux-rendered images for: - test_kickstart__render_PBL_43717 - test_kickstart__render_steps_above_daily_avg - test_kickstart__render_steps_above_daily_avg_24h Co-authored-by: Claude <[email protected]> Signed-off-by: Joseph Mearman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enables the
test_kickstartunit test by adding the required PBI fixture files. The test was previously disabled in the BROKEN_TESTS list due to missing fixture dependencies.Test Fixture Additions
test_kickstartcovering various health and activity rendering scenarios:render_PBL_43681andrender_PBL_43717- PBL health metric renderingrender_hr_bpmandrender_hr_bpm_24h- Heart rate display (12-hour and 24-hour formats)render_hr_bpm_obstructedandrender_hr_bpm_obstructed_24h- Heart rate with obstructionrender_no_data- Empty state renderingrender_obstructed_area- Obstruction area visualizationrender_steps_above_daily_avgandrender_steps_above_daily_avg_24h- Step count above daily averagerender_steps_above_typical- Step count above typical rangerender_steps_below_typical- Step count below typical rangeBROKEN_TESTS Update
test_kickstart.cfrom the BROKEN_TESTS list intests/wscript, allowing the test to compile and run as part of the standard test suite.Impact