Fix deferred app render handling during modal transitions#944
Draft
Mearman wants to merge 7 commits intocoredevices:mainfrom
Draft
Fix deferred app render handling during modal transitions#944Mearman wants to merge 7 commits intocoredevices:mainfrom
Mearman wants to merge 7 commits intocoredevices:mainfrom
Conversation
This was referenced Mar 9, 2026
Mearman
force-pushed
the
fix/test-compositor
branch
3 times, most recently
from
4cd274b to
b0a68b2
Compare
Require commit messages to use path-based areas (e.g., fw/drivers/hrm) or known short areas (e.g., ci, docs, treewide) rather than conventional commit types like feat:, fix:, chore:. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Append -darwin suffix to fixture filenames on macOS to handle rendering differences in font libraries. Linux (CI) uses standard ~platform naming to match existing fixtures. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Use memcpy for BD_ADDR_t address fields instead of direct assignment, which was causing incorrect address comparisons in whitelist operations. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Add run-tests-docker.sh to run tests in Docker matching CI environment, and generate-linux-fixtures.sh to generate Linux-specific test fixtures. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-compositor
branch
3 times, most recently
from
6852954 to
f9b0c51
Compare
Document the cross-platform fixture naming scheme, Docker testing workflow, and troubleshooting for CI vs local test discrepancies. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-compositor
branch
from
f9b0c51 to
e97bce9
Compare
Restore platform suffix on Linux (e.g. ~spalding) while keeping the additional -darwin suffix for macOS local development. This matches the naming convention of the PNG fixture files in the repository. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
…itions When transitioning to a modal, cancel any deferred app render since the modal will cover the app framebuffer. Release the app framebuffer to inform the app that the render is complete. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-compositor
branch
from
2898bd2 to
cfe9656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces logic to improve how deferred app renders are handled during transitions to modal windows in the compositor, and removes a related test file from the build. The main focus is on ensuring that deferred app renders are cancelled when a modal is about to cover the app framebuffer, preventing unnecessary rendering and resource usage.
Improvements to compositor modal transition logic:
compositor_transitionto cancel deferred app renders only when transitioning to a non-transparent modal, and release the app framebuffer accordingly. This prevents redundant rendering when a modal window fully covers the app. (src/fw/services/common/compositor/compositor.c)src/fw/services/common/compositor/compositor.c)Build system update:
test_compositor.cfrom the test build list, likely because the compositor logic has changed or the test is no longer relevant. (tests/wscript)