refactor: kind of everything #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimize Loc::new() to eliminate string allocations during byte-to-char conversion - Replace HashMap with IndexMap for better cache performance in models - Use SmallVec for commonly small collections (ranges, statements, declarations) - Flatten cache structure with combined keys for better memory layout - Optimize merge operations to use HashSet for O(1) lookup instead of dedup_by - Add helper functions for efficient data structure conversions - Use more efficient parallel processing patterns Co-authored-by: MuntasirSZN <[email protected]>
- Update miri_tests.rs to use constructors instead of direct struct initialization - Replace Vec::new() with appropriate SmallVec constructors in tests - Fix capacity assertions to match SmallVec minimums - Ensure all tests compile and run correctly with new optimized data structures Co-authored-by: MuntasirSZN <[email protected]>
…omprehensive configuration Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
…timizations Co-authored-by: MuntasirSZN <[email protected]>
chore: another clippy fix Update docs/cache-configuration.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update src/bin/core/cache.rs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update src/cache.rs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> remove allow unused
Co-authored-by: MuntasirSZN <[email protected]>
…used code Co-authored-by: MuntasirSZN <[email protected]>
… checks Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
…opying code Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
Co-authored-by: MuntasirSZN <[email protected]>
Collaborator
Author
no resolve button? @cordx56 see unoutdated ones only...
|
Owner
Okay, but this PR is sent from your repo. Maybe I can't edit your repo, right? |
Collaborator
Author
You can. You are maintainer. Maintainer has edit access (regardless if repo of its own or not, just pr from that branch or repo). @cordx56 |
MuntasirSZN
added
do-build-check
Collaborator
Author
|
I removed do-build-check label, now all test, lint and build run in all targets. Also made build explicit so we don't have to know which target belongs to which os. |
Design - Resumable downloads - Download to disk (~/.rustowl/.rustowl-cache) - After full download done, extract sync Every component is downloaded and extarcted in parallel. We still stream to disk, but removed pipe as complex and we are not using it for anything else. We are using full download and extract after done. Reasoning: - In zip format, seeking while streaming is impossible (possible, with numerous caveats, and its not the way zip is made) - Tar is good, but two implementations, tar stream extract and zip full download and extract. So we unify to one way. FULL download and extract after done. Download is resumable, also download is streamed to disk, so memory usage is low.
MuntasirSZN
force-pushed
the
feat/test-frenzy
branch
from
f911159 to
d0e9cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.