Prevent concurrent cache access#135
Merged
Merged
Conversation
kolov
approved these changes
May 21, 2024
Merged
rtimush
added a commit
that referenced
this pull request
May 22, 2024
## 🤖 New release * `protofetch`: 0.1.3 -> 0.1.4 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.4](v0.1.3...v0.1.4) - 2024-05-22 ### Other - Prevent concurrent cache access ([#135](#135)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgit2fails if we try to access the same cached repository concurrently. This is however very likely to happen when multiple projects in cargo workspace use protofetch to fetch from the same source.This PR makes protofetch acquire a lock on the cache directory before accessing it, so only one instance can work with the cache at a time. The lock is not granular, but it should be good enough.